Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(core): re-enable CRA migration to Vite #30082

Merged
merged 6 commits into from
Feb 25, 2025
Merged

fix(core): re-enable CRA migration to Vite #30082

merged 6 commits into from
Feb 25, 2025

Conversation

jaysoo
Copy link
Member

@jaysoo jaysoo commented Feb 18, 2025

This PR brings back the CRA migration that was missing since Nx 18.

Current Behavior

nx init does not migrate CRA apps

Expected Behavior

nx init migrates CRA apps to Vite since CRA is deprecated

Related Issue(s)

Fixes #

Copy link

vercel bot commented Feb 18, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Skipped Deployment
Name Status Preview Updated (UTC)
nx-dev ⬜️ Ignored (Inspect) Visit Preview Feb 25, 2025 5:22pm

Copy link

nx-cloud bot commented Feb 18, 2025

View your CI Pipeline Execution ↗ for commit 63aa243.

Command Status Duration Result
nx affected --targets=lint,test,build,e2e,e2e-c... ✅ Succeeded 26m 33s View ↗
nx run-many -t check-imports check-commit check... ✅ Succeeded 19s View ↗
nx-cloud record -- nx-cloud conformance:check ✅ Succeeded 2s View ↗
nx-cloud record -- nx format:check --base= --he... ✅ Succeeded 7s View ↗
nx-cloud record -- nx sync:check ✅ Succeeded 5s View ↗
nx documentation ✅ Succeeded 34s View ↗

☁️ Nx Cloud last updated this comment at 2025-02-25 17:53:08 UTC

@jaysoo jaysoo force-pushed the fix/cra-init branch 3 times, most recently from 55e49bf to 1f05c4d Compare February 18, 2025 18:29
@jaysoo jaysoo marked this pull request as ready for review February 18, 2025 18:30
@jaysoo jaysoo requested review from a team as code owners February 18, 2025 18:30
@jaysoo jaysoo force-pushed the fix/cra-init branch 6 times, most recently from c44121f to 8fdf221 Compare February 18, 2025 21:37
Copy link

🐳 We have a release for that!

This PR has a release associated with it. You can try it out using this command:

npx create-nx-workspace@0.0.0-pr-30082-6c4c183 my-workspace

Or just copy this version and use it in your own command:

0.0.0-pr-30082-6c4c183
Release details 📑
Published version 0.0.0-pr-30082-6c4c183
Triggered by @jaysoo
Branch fix/cra-init
Commit 6c4c183
Workflow run 13422710753

To request a new release for this pull request, mention someone from the Nx team or the @nrwl/nx-pipelines-reviewers.

@jaysoo jaysoo force-pushed the fix/cra-init branch 3 times, most recently from 82f7769 to f9a5277 Compare February 24, 2025 21:41
@jaysoo jaysoo requested a review from a team as a code owner February 25, 2025 13:51
Copy link
Member

@juristr juristr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

works. thank you.

@jaysoo jaysoo merged commit 202b49b into master Feb 25, 2025
12 checks passed
@jaysoo jaysoo deleted the fix/cra-init branch February 25, 2025 19:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants