Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(core): ensure local plugin is transpiled when using index files #30133

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

Roozenboom
Copy link
Contributor

@Roozenboom Roozenboom commented Feb 21, 2025

Current Behavior

In some use cases the local plugins generators and executors are not transpiled, which causes an error when you execute them. see for example
Screenshot 2025-02-21 at 09 07 10

This issue is introduced by this PR #29539 and is actually a regression of an error we had in NX 18, see #22958

Expected Behavior

This PR fixes this issue by updating the if statement to register the typescript transpiler when this is not done yet.

Related Issue(s)

Fixes #30132

@Roozenboom Roozenboom requested a review from a team as a code owner February 21, 2025 11:01
Copy link

vercel bot commented Feb 21, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
nx-dev ✅ Ready (Inspect) Visit Preview Feb 25, 2025 0:32am

Copy link

nx-cloud bot commented Feb 21, 2025

View your CI Pipeline Execution ↗ for commit 3a36649.

Command Status Duration Result
nx affected --targets=lint,test,build,e2e,e2e-c... ✅ Succeeded 35m 51s View ↗
nx run-many -t check-imports check-commit check... ✅ Succeeded 15s View ↗
nx-cloud record -- nx-cloud conformance:check ✅ Succeeded 2s View ↗
nx-cloud record -- nx format:check --base= --he... ✅ Succeeded 6s View ↗
nx-cloud record -- nx sync:check ✅ Succeeded 5s View ↗
nx documentation ✅ Succeeded 1m 6s View ↗

☁️ Nx Cloud last updated this comment at 2025-02-25 13:02:45 UTC

@Roozenboom Roozenboom force-pushed the fix/local-plugin-module-not-found branch from 0108a20 to d0f029b Compare February 21, 2025 15:13
@Roozenboom Roozenboom force-pushed the fix/local-plugin-module-not-found branch from d0f029b to 80e7a9e Compare February 25, 2025 12:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Local plugin executor throws "Cannot find module" error after upgrade to NX 20.3.2
1 participant