Add support for eslint-config-prettier v10 to disable stylistic eslint rules that would conflict with prettier #30166
+1
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Skipped Deployment
|
|
View your CI Pipeline Execution ↗ for commit c74a134.
☁️ Nx Cloud last updated this comment at |
thdk
force-pushed
the
feat/support-eslint-stylistic-rules
branch
from
d60f6b0 to
cd361ef
Compare
Release notes for eslint-config-prettier: https://github.com/prettier/eslint-config-prettier/releases
thdk
force-pushed
the
feat/support-eslint-stylistic-rules
branch
from
c2fda7f to
c74a134
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Current Behavior
Currently
@nx/eslint-pluginhas an optional peer dependency on eslint-config-prettier@9.Expected Behavior
@nx/eslint-pluginshould also alloweslint-config-prettier@10since that release has brought support for stylistic eslint rules and it still works with eslint 9.https://github.com/prettier/eslint-config-prettier/releases/tag/v10.0.0
Related Issue(s)
Didn't log an issue. Let me know if an issue is required.