fix(module-federation): handle parsing static remote config correctly #30168
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Skipped Deployment
|
|
View your CI Pipeline Execution ↗ for commit fe807ed.
☁️ Nx Cloud last updated this comment at |
jaysoo
reviewed
Feb 25, 2025
packages/module-federation/src/utils/parse-static-remotes-config.ts
Outdated
Show resolved
Hide resolved
Coly010
force-pushed
the
module-federation/ensure-remote-dist-copied-correctly
branch
from
01517bb to
fe807ed
Compare
jaysoo
approved these changes
Feb 25, 2025
Coly010
deleted the
module-federation/ensure-remote-dist-copied-correctly
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Current Behavior
When the dist for a project lives in the projectRoot, the
parseStaticRemotesConfigutil function for executors is not correctly handling the outputPath and urlSegmentExpected Behavior
Ensure that the parsed config is correct regardless of whether the dist is in the projectRoot or not
Related Issue(s)
Fixes #30138