test: get planet #13
Open
test: get planet #13
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Nuevos tests para validar que un planeta exista y que no exista.
|
Your Render PR Server URL is https://planetas-api-pr-13.onrender.com. Follow its progress at https://dashboard.render.com/web/srv-cj7bch6e546c738v6j70. |
Nuevos tests para validar que un planeta exista y que no exista.
Nuevos tests para validar que un planeta exista y que no exista.
|
@nsdonato no puedo probar si corren los test de ejemplo en el CI porque no detecta el deploy a partir de una PR. No queda otra que aceptar y probar directo en producción. Cuando aceptes sería bueno hacer squash así si hay que revertir algo no tenemos que mover los 3 commits de mis pruebas. |
nsdonato
reviewed
Aug 8, 2023
| on: | ||
| push: | ||
| branches: [main] | ||
| jobs: | ||
| deploy: | ||
| name: Wait for Deploy | ||
| check-deploy: |
There was a problem hiding this comment.
esto podríamos dejarlo en deploy? no se si hace diferencia pero en el readme de como usar el GA decía deploy, (por las dudas).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Nuevos tests para validar que un planeta exista y que no exista.