-
Notifications
You must be signed in to change notification settings - Fork 97
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add option to search for collections without granules #940
Conversation
I will automatically update this comment whenever this PR is modified
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👋 Hi Julia! Welcome, and thanks so much for your contribution!
LGTM with minor suggestion :)
What's up with ReadTheDocs?
😖 |
Co-authored-by: Matt Fisher <3608264+mfisher87@users.noreply.github.com>
I sure hope you don't expect me to know the answer to that one! |
https://github.com/mkdocstrings/mkdocstrings/releases/tag/0.28.0 |
The error seems to be because this config key is no longer supported, or was renamed: Lines 46 to 48 in 762c2a2
|
Co-authored-by: Chuck Daniels <cjdaniels4@gmail.com>
@mfisher87 @chuckwondo Typos have been updated -- please take one more look in case my stress-addled brain missed anything else. Matt, do you want me to add a ReadTheDocs fix to this PR? |
I opened #941 :) |
@juliacollins could you merge in main for a ✨ green check? |
Co-authored-by: Chuck Daniels <cjdaniels4@gmail.com>
Co-authored-by: Chuck Daniels <cjdaniels4@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @juliacollins!
Thanks @juliacollins ! |
Thanks for your help @mfisher87 and @chuckwondo! |
@juliacollins Would releasing this feature soon be useful to you? Or is it not urgent for your work? |
Releasing soon is very useful. I was just chatting with @betolink about this! I need to head to a planning meeting but can follow up on earthaccess logistics around noon. Feel free to launch a new release in the meantime ;-) otherwise this can be a learning experience for me. |
Extend
search_datasets
API to allow a false value forhas_granules
when querying CMR. See #939Pull Request (PR) draft checklist - click to expand
contributing documentation
before getting started.
title such as "Add testing details to the contributor section of the README".
Example PRs: #763
example
closes #1
. SeeGitHub docs - Linking a pull request to an issue.
CHANGELOG.md
with details about your change in a section titled## Unreleased
. If such a section does not exist, please create one. FollowCommon Changelog for your additions.
Example PRs: #763
README.md
with details of changes to theearthaccess interface, if any. Consider new environment variables, function names,
decorators, etc.
Click the "Ready for review" button at the bottom of the "Conversation" tab in GitHub
once these requirements are fulfilled. Don't worry if you see any test failures in
GitHub at this point!
Pull Request (PR) merge checklist - click to expand
Please do your best to complete these requirements! If you need help with any of these
requirements, you can ping the
@nsidc/earthaccess-support
team in a comment and wewill help you out!
Request containing "pre-commit.ci autofix" to automate this.
📚 Documentation preview 📚: https://earthaccess--940.org.readthedocs.build/en/940/