Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add option to search for collections without granules #940

Merged
merged 6 commits into from
Feb 10, 2025

Conversation

juliacollins
Copy link
Contributor

@juliacollins juliacollins commented Feb 7, 2025

Extend search_datasets API to allow a false value for has_granules when querying CMR. See #939

Pull Request (PR) draft checklist - click to expand
  • [X ] Please review our
    contributing documentation
    before getting started.
  • [X ] Populate a descriptive title. For example, instead of "Updated README.md", use a
    title such as "Add testing details to the contributor section of the README".
    Example PRs: #763
  • [X ] Populate the body of the pull request with:
  • [X ] Update CHANGELOG.md with details about your change in a section titled
    ## Unreleased. If such a section does not exist, please create one. Follow
    Common Changelog for your additions.
    Example PRs: #763
  • [X ] Update the documentation and/or the README.md with details of changes to the
    earthaccess interface, if any. Consider new environment variables, function names,
    decorators, etc.

Click the "Ready for review" button at the bottom of the "Conversation" tab in GitHub
once these requirements are fulfilled. Don't worry if you see any test failures in
GitHub at this point!

Pull Request (PR) merge checklist - click to expand

Please do your best to complete these requirements! If you need help with any of these
requirements, you can ping the @nsidc/earthaccess-support team in a comment and we
will help you out!

  • [X ] Add unit tests for any new features.
  • [X ] Apply formatting and linting autofixes. You can add a GitHub comment in this Pull
    Request containing "pre-commit.ci autofix" to automate this.
  • Ensure all automated PR checks (seen at the bottom of the "conversation" tab) pass.
  • Get at least one approving review.

📚 Documentation preview 📚: https://earthaccess--940.org.readthedocs.build/en/940/

Copy link

github-actions bot commented Feb 7, 2025

Binder 👈 Launch a binder notebook on this branch for commit bd3eab5

I will automatically update this comment whenever this PR is modified

Binder 👈 Launch a binder notebook on this branch for commit f909ea5

Binder 👈 Launch a binder notebook on this branch for commit 11ffbd6

Binder 👈 Launch a binder notebook on this branch for commit 4858de1

Binder 👈 Launch a binder notebook on this branch for commit 5cb7e5c

Binder 👈 Launch a binder notebook on this branch for commit 1a2b2bf

@juliacollins juliacollins marked this pull request as ready for review February 7, 2025 20:43
mfisher87
mfisher87 previously approved these changes Feb 7, 2025
Copy link
Collaborator

@mfisher87 mfisher87 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👋 Hi Julia! Welcome, and thanks so much for your contribution!

LGTM with minor suggestion :)

@mfisher87
Copy link
Collaborator

What's up with ReadTheDocs?

TypeError: PythonConfig.__init__() got an unexpected keyword argument 'rendering'

😖

Co-authored-by: Matt Fisher <3608264+mfisher87@users.noreply.github.com>
@juliacollins
Copy link
Contributor Author

What's up with ReadTheDocs?

TypeError: PythonConfig.__init__() got an unexpected keyword argument 'rendering'

😖

I sure hope you don't expect me to know the answer to that one!

@mfisher87
Copy link
Collaborator

mfisher87 commented Feb 7, 2025

mkdocstrings had a release 4 days ago and it seems our builds have failed since then

https://github.com/mkdocstrings/mkdocstrings/releases/tag/0.28.0

@mfisher87
Copy link
Collaborator

mfisher87 commented Feb 7, 2025

The error seems to be because this config key is no longer supported, or was renamed:

earthaccess/mkdocs.yml

Lines 46 to 48 in 762c2a2

rendering:
show_root_heading: false
show_source: false

Co-authored-by: Chuck Daniels <cjdaniels4@gmail.com>
@juliacollins
Copy link
Contributor Author

@mfisher87 @chuckwondo Typos have been updated -- please take one more look in case my stress-addled brain missed anything else. Matt, do you want me to add a ReadTheDocs fix to this PR?

@mfisher87
Copy link
Collaborator

mfisher87 commented Feb 7, 2025

Matt, do you want me to add a ReadTheDocs fix to this PR?

I opened #941 :)

@mfisher87
Copy link
Collaborator

@juliacollins could you merge in main for a ✨ green check?

juliacollins and others added 3 commits February 9, 2025 21:41
Co-authored-by: Chuck Daniels <cjdaniels4@gmail.com>
Co-authored-by: Chuck Daniels <cjdaniels4@gmail.com>
Copy link
Collaborator

@chuckwondo chuckwondo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @juliacollins!

@mfisher87 mfisher87 merged commit 3f8b03a into nsidc:main Feb 10, 2025
13 checks passed
@mfisher87
Copy link
Collaborator

Thanks @juliacollins !

@juliacollins juliacollins deleted the issue-939 branch February 10, 2025 16:31
@juliacollins
Copy link
Contributor Author

Thanks for your help @mfisher87 and @chuckwondo!

@mfisher87
Copy link
Collaborator

@juliacollins Would releasing this feature soon be useful to you? Or is it not urgent for your work?

@juliacollins
Copy link
Contributor Author

@juliacollins Would releasing this feature soon be useful to you? Or is it not urgent for your work?

Releasing soon is very useful. I was just chatting with @betolink about this! I need to head to a planning meeting but can follow up on earthaccess logistics around noon. Feel free to launch a new release in the meantime ;-) otherwise this can be a learning experience for me.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants