Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Document step to create a branch and PR when releasing #950

Merged
merged 6 commits into from
Feb 12, 2025

Conversation

mfisher87
Copy link
Collaborator

@mfisher87 mfisher87 commented Feb 11, 2025

Pull Request (PR) draft checklist - click to expand
  • Please review our
    contributing documentation
    before getting started.
  • Populate a descriptive title. For example, instead of "Updated README.md", use a
    title such as "Add testing details to the contributor section of the README".
    Example PRs: #763
  • Populate the body of the pull request with:
  • Update CHANGELOG.md with details about your change in a section titled
    ## Unreleased. If such a section does not exist, please create one. Follow
    Common Changelog for your additions.
    Example PRs: #763
  • Update the documentation and/or the README.md with details of changes to the
    earthaccess interface, if any. Consider new environment variables, function names,
    decorators, etc.

Click the "Ready for review" button at the bottom of the "Conversation" tab in GitHub
once these requirements are fulfilled. Don't worry if you see any test failures in
GitHub at this point!

Pull Request (PR) merge checklist - click to expand

Please do your best to complete these requirements! If you need help with any of these
requirements, you can ping the @nsidc/earthaccess-support team in a comment and we
will help you out!

  • Add unit tests for any new features.
  • Apply formatting and linting autofixes. You can add a GitHub comment in this Pull
    Request containing "pre-commit.ci autofix" to automate this.
  • Ensure all automated PR checks (seen at the bottom of the "conversation" tab) pass.
  • Get at least one approving review.

📚 Documentation preview 📚: https://earthaccess--950.org.readthedocs.build/en/950/

Copy link

github-actions bot commented Feb 11, 2025

Binder 👈 Launch a binder notebook on this branch for commit 8e025d7

I will automatically update this comment whenever this PR is modified

Binder 👈 Launch a binder notebook on this branch for commit dd11c8a

Binder 👈 Launch a binder notebook on this branch for commit f4a4c61

Binder 👈 Launch a binder notebook on this branch for commit 577d439

@mfisher87 mfisher87 marked this pull request as ready for review February 11, 2025 23:51
@mfisher87 mfisher87 changed the title Add step to create a branch when releasing Add step to create a branch and PR when releasing Feb 11, 2025
@mfisher87 mfisher87 added the impact: documentation Improvements or additions to documentation label Feb 11, 2025
juliacollins
juliacollins previously approved these changes Feb 12, 2025
@mfisher87 mfisher87 changed the title Add step to create a branch and PR when releasing Document step to create a branch and PR when releasing Feb 12, 2025
@mfisher87
Copy link
Collaborator Author

mfisher87 commented Feb 12, 2025

I'm going to count this approval as still valid since my only change was to fix a formatting mistake.

Naughty-merge!

@mfisher87 mfisher87 merged commit 74c0ef5 into nsidc:main Feb 12, 2025
7 of 8 checks passed
@mfisher87 mfisher87 deleted the releasing-docs branch February 12, 2025 16:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
impact: documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants