Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update with native EL8/EL9 instructions #38

Merged
merged 5 commits into from
Feb 26, 2025
Merged

Update with native EL8/EL9 instructions #38

merged 5 commits into from
Feb 26, 2025

Conversation

nsmith-
Copy link
Owner

@nsmith- nsmith- commented May 17, 2024

No description provided.

@nsmith-
Copy link
Owner Author

nsmith- commented May 17, 2024

Arguably we should checkout a specific combine version, e.g.

cd HiggsAnalysis/CombinedLimit
git co v9.2.1
cd ../..

@nsmith-
Copy link
Owner Author

nsmith- commented Feb 26, 2025

We could start minting releases and actually pushing to pypi rather than installing from git. @rkansal47 thoughts?

@rkansal47
Copy link
Collaborator

@nsmith- I agree. Actually I think we already started doing that :) https://pypi.org/project/rhalphalib, but there just haven't been any major updates since then (until now).

@rkansal47
Copy link
Collaborator

Wow this is working with CMSSW_14_1_0_pre4 now with your fixes from #42?? 🎉

@nsmith-
Copy link
Owner Author

nsmith- commented Feb 26, 2025

Ok, can you approve & merge this? I'll work on making sure the release pipeline still works

@nsmith-
Copy link
Owner Author

nsmith- commented Feb 26, 2025

yeah specifically 456e903 was what seemed to be breaking newer ROOT versions.

@rkansal47
Copy link
Collaborator

Yes, testing now on an el8 machine.

Copy link
Collaborator

@rkansal47 rkansal47 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Worked perfectly on el8, thanks! Finally, we can stop using el7 containers...

@rkansal47
Copy link
Collaborator

Oof why is the test failing now?

@nsmith-
Copy link
Owner Author

nsmith- commented Feb 26, 2025

The conda install seems to be a bit flaky

@nsmith-
Copy link
Owner Author

nsmith- commented Feb 26, 2025

Looks like this is a well-known thing and hopefully will be fixed soon: conda-incubator/setup-miniconda#392
For now I guess I'll re-run

@nsmith- nsmith- merged commit 41a6d84 into master Feb 26, 2025
4 checks passed
@nsmith- nsmith- deleted the el8 branch February 26, 2025 23:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants