-
Notifications
You must be signed in to change notification settings - Fork 19
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update with native EL8/EL9 instructions #38
Conversation
Arguably we should checkout a specific combine version, e.g.
|
We could start minting releases and actually pushing to pypi rather than installing from git. @rkansal47 thoughts? |
@nsmith- I agree. Actually I think we already started doing that :) https://pypi.org/project/rhalphalib, but there just haven't been any major updates since then (until now). |
Wow this is working with CMSSW_14_1_0_pre4 now with your fixes from #42?? 🎉 |
Ok, can you approve & merge this? I'll work on making sure the release pipeline still works |
yeah specifically 456e903 was what seemed to be breaking newer ROOT versions. |
Yes, testing now on an el8 machine. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Worked perfectly on el8, thanks! Finally, we can stop using el7 containers...
Oof why is the test failing now? |
The conda install seems to be a bit flaky |
Looks like this is a well-known thing and hopefully will be fixed soon: conda-incubator/setup-miniconda#392 |
No description provided.