ir: Support auto-deployment in non-local consensus launch mode #2665
Conversation
cthulhu-rider
requested review from
roman-khimov and
carpawell
as code owners
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## master #2665 +/- ##
==========================================
- Coverage 30.22% 30.06% -0.16%
==========================================
Files 406 406
Lines 30025 30174 +149
==========================================
- Hits 9075 9072 -3
- Misses 20170 20321 +151
- Partials 780 781 +1 ☔ View full report in Codecov by Sentry. |
cthulhu-rider
force-pushed
the
feature/non-local-autodeploy
branch
4 times, most recently
from
8461331 to
ec0492d
Compare
| client *client.Client | ||
|
|
||
| netmapContractMtx sync.RWMutex | ||
| netmapContract *netmap.Client | ||
|
|
||
| *rpcclient.WSClient | ||
| wsClient *rpcclient.WSClient |
There was a problem hiding this comment.
I'm not sure why neoFSSidechainCommonRPC (or any other similar interface) is not enough.
There was a problem hiding this comment.
as we discussed client.Client and rpcclient.WSClient cannot share the whole needed interface due to event listening methods. Another inconvenience is that client.Client is one-time in terms of subscriptions. So, for non-local consensus we use client.Client dedicated for deployment only (opened, used, closed, then use another instance), while in local one we use single (local) rpcclient.WSClient with which we can cancel deploy subscriptions and continue as if from scratch
i could have 2 different types for these 2 modes, but decided to not do so for now
see guess it wants NNS e-mail config neofs-node/config/example/ir.yaml Lines 83 to 84 in 752d8a7 |
|
That's dev-env and it's still deployed with neofs-adm, I expect it to work as it worked before. And likely some default (nonexistent@nspcc.io) would be handy as well, not a lot of people care about this e-mail. |
done |
|
Still isn't healthy. |
There is a need to interchange single-endpoint WebSocket Neo RPC client with the multi-endpoint one. Previously, multi-client did not expose some needed methods or did it with other signature and/or behavior. Inherit subset of `rpcclient.WSClient` method in multi `client.Client`. Subscriptions are left untouched. Refs #2195. Signed-off-by: Leonard Lyubich <leonard@morphbits.io>
The method is completely unusable because it accepts nowhere defined subscription ID. Signed-off-by: Leonard Lyubich <leonard@morphbits.io>
Signed-off-by: Leonard Lyubich <leonard@morphbits.io>
Transaction signer parameter is not a filter: it extends event stream with specific notary requests, not filters out the other ones added the same way. Signed-off-by: Leonard Lyubich <leonard@morphbits.io>
Not expected in practice, but still have to be checked. Signed-off-by: Leonard Lyubich <leonard@morphbits.io>
Signed-off-by: Leonard Lyubich <leonard@morphbits.io>
Previously, notary request events were always filtered by main transactions' signers, therefore it was impossible to subscribe to all notary request events. Newly added method `ReceiveAllNotaryRequests` will be useful for components that want to receive all notary requests. Signed-off-by: Leonard Lyubich <leonard@morphbits.io>
All notary requests are listened, not only the committee ones. Signed-off-by: Leonard Lyubich <leonard@morphbits.io>
Deploy procedure sometimes waits for a new block from the blockchain. Previously, waiting could be interrupted by the global context only. This did not allow waiting to be interrupted when the event stream was interrupted (which usually means the connection was lost). Closing the channel of new blocks will now result in a lost connection error returned from the deployment procedure. Signed-off-by: Leonard Lyubich <leonard@morphbits.io>
Previously, `deploy.Blockchain` interface had same event subscription interface as Neo RPC WebSocket client in Neo Go lib. Although this made it possible to directly use `rpcclient.WSClient` as an instance, the interface itself was over-saturated with respect to its use in the deployment procedure. In particular, event filtering was never done and events were never demuxed. Also, the previous version of the interface made it impossible to use a client connected to several endpoints. Based on these considerations, the interface is simplified. As a result, it is now possible to provide an interface from a multi-endpoint client. Signed-off-by: Leonard Lyubich <leonard@morphbits.io>
Previously, Inner Ring app did not start Sidechain auto-deployment and update procedure in non-local consensus launch mode. While pure remote RPC configuration is supported, auto-deployment must not depend on consensus locality. The only difference is that remote configuration should support multiple endpoints. Refs #2195. Signed-off-by: Leonard Lyubich <leonard@morphbits.io>
Previously, Inner Ring app required `nns.system_email` config to be set. Since NNS emails are not something meaningful, it makes sense to use some default one. Assign `nonexistent@nspcc.io` email to the NNS domains registered during FS chain deployment by default. Refs #2195. Signed-off-by: Leonard Lyubich <leonard@morphbits.io>
cthulhu-rider
force-pushed
the
feature/non-local-autodeploy
branch
from
a18d1ba to
c92556a
Compare
|
fixed, should work now |
No description provided.