cli: Use MarkFlagsOneRequired for mutex but required flags
#2763
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #2763 +/- ##
=======================================
Coverage 22.03% 22.04%
=======================================
Files 787 787
Lines 46763 46751 -12
=======================================
Hits 10304 10304
+ Misses 35576 35564 -12
Partials 883 883 ☔ View full report in Codecov by Sentry. |
roman-khimov
approved these changes
Mar 5, 2024
The feature came with github.com/spf13/cobra@v1.8.0. We don't need to do manual checks with it. For example, following command result changed from: ``` $ neofs-cli bearer create -i 1 -n 2 --out b -o c expiration epoch or lifetime period is required ``` to ``` Error: at least one of the flags in the group [expire-at lifetime] is required ``` Ret code remains = 1. Below are command checklists. CLI: * `bearer create`; * `control shards evacuate`; * `control shards flush-cache`; * `control shards set-mode`; * `object lock`; * `session create`; * `storagegroup put`. ADM: * `morph verified-nodes-domain set-access-list`; * `morph refill-gas`. Closes #2595. Signed-off-by: Leonard Lyubich <leonard@morphbits.io>
cthulhu-rider
force-pushed
the
2595-cli-oneof-flag
branch
from
9c077c1 to
8883373
Compare
carpawell
approved these changes
Mar 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.