gRPC TLS fixes #2764
Merged
gRPC TLS fixes #2764
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The gRPC lib defaults min accepted TLS version to 1.2 since release v1.60.0 (grpc/grpc-go#6758). Refs #2755. Signed-off-by: Leonard Lyubich <leonard@morphbits.io>
Insecure cipher suites must never be allowed. Refs #2755. Signed-off-by: Leonard Lyubich <leonard@morphbits.io>
The gRPC lib defaults to all secure TLS cipher suites supported by Go stdlib since release v1.60.0 (grpc/grpc-go#6758). Previously passed handwritten ciphers remained the same. Closes #2755. Signed-off-by: Leonard Lyubich <leonard@morphbits.io>
roman-khimov
approved these changes
Mar 5, 2024
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #2764 +/- ##
=======================================
Coverage 22.03% 22.03%
=======================================
Files 787 787
Lines 46763 46750 -13
=======================================
- Hits 10304 10302 -2
+ Misses 35576 35565 -11
Partials 883 883 ☔ View full report in Codecov by Sentry. |
carpawell
approved these changes
Mar 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.