node: Use github.com/nspcc-dev/neofs-api-go/v2 module less
#3079
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #3079 +/- ##
==========================================
- Coverage 22.14% 22.12% -0.03%
==========================================
Files 794 794
Lines 59484 59563 +79
==========================================
+ Hits 13175 13176 +1
- Misses 45405 45483 +78
Partials 904 904 ☔ View full report in Codecov by Sentry. |
This was the only direct importer of to-be-deprecated `neofs-api-go/v2` module in `pkg/local_object_storage` space. Signed-off-by: Leonard Lyubich <leonard@morphbits.io>
cthulhu-rider
force-pushed
the
avoid-apigo-req-forwarding
branch
2 times, most recently
from
798d7a0 to
cf96d43
Compare
cthulhu-rider
requested review from
roman-khimov and
carpawell
as code owners
This refactors storage node app making it to use gRPC connection to remote nodes for request forwarding without wrappers. The behavior is preserved with some error text added/changed for the better. Avoid importing `github.com/nspcc-dev/neofs-api-go/v2/rpc` packages. The only place left will naturally go with coming SDK upgrade. One step closer to whole `neofs-api-go` module's deprecation. Signed-off-by: Leonard Lyubich <leonard@morphbits.io>
cthulhu-rider
force-pushed
the
avoid-apigo-req-forwarding
branch
from
8a9237a to
fdc0a42
Compare
|
sure, fixed |
roman-khimov
approved these changes
Jan 13, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
one more cut from #3057, continues #3078