Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cmd: disable zap log sampling #1024

Merged
merged 1 commit into from
Nov 13, 2024
Merged

cmd: disable zap log sampling #1024

merged 1 commit into from
Nov 13, 2024

Conversation

roman-khimov
Copy link
Member

Skipping log lines is not safe to be used by default. Notice that s3-authmate doesn't have this problem because of the way it constructs its settings.

See also:

Skipping log lines is not safe to be used by default. Notice that s3-authmate
doesn't have this problem because of the way it constructs its settings.

See also:
 * nspcc-dev/neofs-node#3011
 * nspcc-dev/neo-go#598

Signed-off-by: Roman Khimov <roman@nspcc.ru>
@roman-khimov roman-khimov added this to the v0.33.0 milestone Nov 13, 2024
@roman-khimov roman-khimov merged commit 231599c into master Nov 13, 2024
13 of 16 checks passed
@roman-khimov roman-khimov deleted the fix-log-sampling branch November 13, 2024 12:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants