Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove re-slicing for multipart #931
Remove re-slicing for multipart #931
Changes from all commits
e7d03c3
a079f9c
ef9a5ba
2732c93
a748b72
2548e50
127dd3e
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
Check warning on line 1466 in api/handler/acl.go
api/handler/acl.go#L1466
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
IMO, a potential OOM killer is here, the same way we already fixed this in SDK
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Links to changes, please
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Using
sync.Pool
showed better memory using profile after load tests. It Already works hereneofs-s3-gw/internal/neofs/neofs.go
Line 331 in 4717bd8
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nspcc-dev/neofs-sdk-go#539
yes, but putting 1K objects 1-byte sized simultaneously leads to 64GB memory usage but requires only 1KB in fact. we already know we may be quite successive at running out of 1TB memory, not a cool story
but ok, as i understand we will return to this later
Check warning on line 275 in api/layer/layer.go
api/layer/layer.go#L273-L275