Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

slicer: Do not drop link object's payload #560

Merged
merged 1 commit into from
Feb 28, 2024

Conversation

carpawell
Copy link
Member

Another header == object cool thing.

@carpawell
Copy link
Member Author

Oh, well, let's test it.

@carpawell carpawell marked this pull request as draft February 27, 2024 22:20
@carpawell carpawell force-pushed the fix/slicer-drops-link-payload branch 2 times, most recently from 8af8c9f to f0c54e0 Compare February 28, 2024 12:35
@carpawell carpawell marked this pull request as ready for review February 28, 2024 12:35
@carpawell carpawell force-pushed the fix/slicer-drops-link-payload branch 2 times, most recently from 799a1b6 to 51085be Compare February 28, 2024 15:58
Another header == object cool thing. Also, improve tests a little: fix payload
size, reject using deprecated things.

Signed-off-by: Pavel Karpy <carpawell@nspcc.ru>
@carpawell carpawell force-pushed the fix/slicer-drops-link-payload branch from 51085be to 44a2cc4 Compare February 28, 2024 16:22
Copy link
Contributor

@cthulhu-rider cthulhu-rider left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Another header == object cool thing.

can we not write vague and emotional statements in commits?

@roman-khimov roman-khimov merged commit d1bb088 into master Feb 28, 2024
5 checks passed
@roman-khimov roman-khimov deleted the fix/slicer-drops-link-payload branch February 28, 2024 18:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants