client: Isolate dial errors #561
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
cthulhu-rider
commented
Feb 28, 2024
cthulhu-rider
commented
- based on and blocked by Return clear dial errors neofs-api-go#445
cthulhu-rider
requested review from
roman-khimov,
smallhive and
carpawell
as code owners
cthulhu-rider
added a commit
to nspcc-dev/neofs-node
that referenced
this pull request
Feb 28, 2024
This pulls NeoFS SDK version containing fix of the NeoFS API client dial failures nspcc-dev/neofs-sdk-go#561. Previously, any connection errors, including TLS, resulted in waiting for a deadline and returning `context.DeadlineExceeded`. This did not make it possible to distinguish them from timeouts and identify the root cause. In addition, irreparable errors such as an incorrect network address or connection refusal were also reduced to `context.DeadlineExceeded`, even if they were received quickly. This behavior has also been fixed. Fixes #2561. Signed-off-by: Leonard Lyubich <leonard@morphbits.io>
cthulhu-rider
force-pushed
the
client-ret-dial-errors
branch
from
8b8b7e3 to
2ea075a
Compare
Fix came from nspcc-dev/neofs-api-go#445 for the problem described in nspcc-dev/neofs-node#2561. Also now any irreparable errors (like invalid net address or TLS handshake) will be returned immediately, not upon reaching the deadline. Signed-off-by: Leonard Lyubich <leonard@morphbits.io>
cthulhu-rider
force-pushed
the
client-ret-dial-errors
branch
from
2ea075a to
bb7a1eb
Compare
roman-khimov
approved these changes
Feb 28, 2024
cthulhu-rider
added a commit
to nspcc-dev/neofs-node
that referenced
this pull request
Feb 29, 2024
This pulls NeoFS SDK version containing fix of the NeoFS API client dial failures nspcc-dev/neofs-sdk-go#561. Previously, any connection errors, including TLS, resulted in waiting for a deadline and returning `context.DeadlineExceeded`. This did not make it possible to distinguish them from timeouts and identify the root cause. In addition, irreparable errors such as an incorrect network address or connection refusal were also reduced to `context.DeadlineExceeded`, even if they were received quickly. This behavior has also been fixed. Fixes #2561. Signed-off-by: Leonard Lyubich <leonard@morphbits.io>
cthulhu-rider
added a commit
to nspcc-dev/neofs-node
that referenced
this pull request
Mar 4, 2024
This pulls NeoFS API Go version containing fix of the NeoFS API client dial failures nspcc-dev/neofs-sdk-go#561. Previously, any connection errors, including TLS, resulted in waiting for a deadline and returning `context.DeadlineExceeded`. This did not make it possible to distinguish them from timeouts and identify the root cause. In addition, irreparable errors such as an incorrect network address or connection refusal were also reduced to `context.DeadlineExceeded`, even if they were received quickly. This behavior has also been fixed. Fixes #2561. Signed-off-by: Leonard Lyubich <leonard@morphbits.io>
cthulhu-rider
added a commit
to nspcc-dev/neofs-node
that referenced
this pull request
Mar 4, 2024
This pulls NeoFS API Go version containing fix of the NeoFS API client dial failures nspcc-dev/neofs-sdk-go#561. Previously, any connection errors, including TLS, resulted in waiting for a deadline and returning `context.DeadlineExceeded`. This did not make it possible to distinguish them from timeouts and identify the root cause. In addition, irreparable errors such as an incorrect network address or connection refusal were also reduced to `context.DeadlineExceeded`, even if they were received quickly. This behavior has also been fixed. Fixes #2561. Signed-off-by: Leonard Lyubich <leonard@morphbits.io>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.