Free apps from using github.com/nspcc-dev/neofs-api-go/v2 module
#570
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #570 +/- ##
=======================================
Coverage 68.15% 68.16%
=======================================
Files 122 122
Lines 9990 9972 -18
=======================================
- Hits 6809 6797 -12
+ Misses 2805 2800 -5
+ Partials 376 375 -1 ☔ View full report in Codecov by Sentry. |
This was referenced Mar 26, 2024
cthulhu-rider
force-pushed
the
no-apigo
branch
2 times, most recently
from
37f63a8 to
553e2b4
Compare
cthulhu-rider
requested review from
roman-khimov,
smallhive and
carpawell
as code owners
It is in demand by apps exchanging unsigned tokens. Signed-off-by: Leonard Lyubich <leonard@morphbits.io>
They are in demand by apps exchanging unsigned tokens. Signed-off-by: Leonard Lyubich <leonard@morphbits.io>
They are not really needed for eACL setting - convenient methods are provided. But `Filter.Key` method provides access to them, so user should be fully equiped for switching or comparison. Signed-off-by: Leonard Lyubich <leonard@morphbits.io>
No reason to hide it when corresponding setters are provided. While regular user is not so interested in such pretty complex information, it could be required to implement protocol conversions. Signed-off-by: Leonard Lyubich <leonard@morphbits.io>
Еhe need to expand a partially or fully formed storage policy is either absent or fully covered by slice manipulations. The parameter variability is also excessive: by default the list is empty and resetting it by calling it without parameters is difficult to read. Adding elements one-by-one is inefficient in terms of resources. While this is breaking change, it forces more clear app code and performance. Signed-off-by: Leonard Lyubich <leonard@morphbits.io>
roman-khimov
approved these changes
Apr 12, 2024
| @@ -234,23 +234,21 @@ func (r ReplicaDescriptor) SelectorName() string { | |||
| return r.m.GetSelector() | |||
| } | |||
|
|
|||
| // AddReplicas adds a bunch object replica's characteristics. | |||
| // SetReplicas sets list of object replica's characteristics. | |||
There was a problem hiding this comment.
Not sure it's an improvement, but let's see how it goes.
carpawell
reviewed
Apr 12, 2024
| fKeyObjType | ||
| fKeyObjHomomorphicHash | ||
| fKeyObjLast // helper, used in tests | ||
| FilterObjectVersion = v2acl.FilterObjectVersion |
There was a problem hiding this comment.
naming as much straightforward as possible, i dont think writing FilterObjectVersion // object version is needed
smallhive
approved these changes
Apr 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://github.com/nspcc-dev/neo-go/ imports indirectly, all fine. https://github.com/nspcc-dev/neofs-node is maintained in a bundle and can be cleaned up last (not in this PR)
projects: