Fix numeric eACL processing #573
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
cthulhu-rider
commented
Mar 27, 2024
cthulhu-rider
commented
- Invalid behavior with numeric eacl rules neofs-node#2785
Previously, to see 'a OP b' in test cases reader should place set 'a' to the right value and 'b' to the left one. Swapping makes condition desc more natural for eyes and easier to understande. Signed-off-by: Leonard Lyubich <leonard@morphbits.io>
Most of 'a OP b' conditions had incorrect boolean flag to check. Due to this, test could not detect the bug. Signed-off-by: Leonard Lyubich <leonard@morphbits.io>
Previously, `Validator` calculated action for eACL with numeric rules incorrectly. This was caused by inverted comparison of filter and object header values. For example, if rule is applied only to 'attr < 0', the rule was applied to objects with 'attr = 1' and not applied to objects with 'attr = -1'. Now condition is inverted and numeric rules are matched correctly. This also fixes corresponding unit test. Signed-off-by: Leonard Lyubich <leonard@morphbits.io>
cthulhu-rider
requested review from
roman-khimov,
smallhive and
carpawell
as code owners
roman-khimov
approved these changes
Mar 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.