Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Abstract visualizers away from being tied specifically to p5 #41

Closed
gwhitney opened this issue Nov 12, 2021 · 3 comments
Closed

Abstract visualizers away from being tied specifically to p5 #41

gwhitney opened this issue Nov 12, 2021 · 3 comments
Labels
future Not being actively worked on, but might be worked on in the future

Comments

@gwhitney
Copy link
Collaborator

We envision that there may be network visualizers and/or table visualizers and/or ... that will want to use other rendering libraries besides p5. Right now, the VisualizerInterface explicitly supposes that there will be a p5 sketch associated with the visualizer. It should be divided into a generic interface that is agnostic about what is doing the rendering, and a specialized P5VisualizerInterface that extends the generic one and assumes there's a p5 sketch, so that other sorts of visualizers can be introduced into the hierarchy.

@liammulh liammulh added the future Not being actively worked on, but might be worked on in the future label Jun 7, 2022
@gwhitney gwhitney added the meeting To be discussed at weekly meeting label Jul 22, 2022
@gwhitney
Copy link
Collaborator Author

gwhitney commented Jul 22, 2022

Example libraries that one might want to use for visualization: three.js to produce 3D graphics; vis.js for networks and other data structures, including possibly "ordinary" graphs of sequence values; and/or bootstrap-table for tabular data (and quite possibly VisualizerDifference should really be done with a table library rather than p5).

@liammulh
Copy link
Member

See #120 (comment) for how we will proceed.

@liammulh liammulh removed the meeting To be discussed at weekly meeting label Jul 25, 2022
gwhitney added a commit to gwhitney/frontscope that referenced this issue Oct 20, 2022
  Adds a new module `shared/math` that has some convenience
  functions for math in frontscope, especially for working
  with bigints.
  Specifically this first revision has safeNumber, for
  converting to a number with a check for loss of accuracy;
  floorSqrt for finding a bigint square root; modulo for the
  mathematician's modulo of bigints; and powmod for calculating
  a power of a number to some modulus (much more efficiently than
  exponentiating and then modding).

  Also provides documentation and tests for the new features and
  a guide to using bigints in frontscope.

  Resolves numberscope#163.
  Partially addresses numberscope#41.
  Does the first half of numberscope#172.
katestange pushed a commit that referenced this issue Oct 27, 2022
* feat: math utilities for the frontscope

  Adds a new module `shared/math` that has some convenience
  functions for math in frontscope, especially for working
  with bigints.
  Specifically this first revision has safeNumber, for
  converting to a number with a check for loss of accuracy;
  floorSqrt for finding a bigint square root; modulo for the
  mathematician's modulo of bigints; and powmod for calculating
  a power of a number to some modulus (much more efficiently than
  exponentiating and then modding).

  Also provides documentation and tests for the new features and
  a guide to using bigints in frontscope.

  Resolves #163.
  Partially addresses #41.
  Does the first half of #172.

* doc(CONTRIBUTING): make the comment on apis readable on github

* feat(math): Natural log for bigints

* docs/test: Respond to Kate review
@gwhitney
Copy link
Collaborator Author

Accomplished via #277. Closing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
future Not being actively worked on, but might be worked on in the future
Projects
None yet
Development

No branches or pull requests

2 participants