feat: math utilities for the frontscope #177
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adds a new module `shared/math` that has some convenience functions for math in frontscope, especially for working with bigints. Specifically this first revision has safeNumber, for converting to a number with a check for loss of accuracy; floorSqrt for finding a bigint square root; modulo for the mathematician's modulo of bigints; and powmod for calculating a power of a number to some modulus (much more efficiently than exponentiating and then modding). Also provides documentation and tests for the new features and a guide to using bigints in frontscope. Resolves numberscope#163. Partially addresses numberscope#41. Does the first half of numberscope#172.
|
Note that the update to vite and the addition to vite.config.ts were necessitated because the previous setup caused |
liammulh
reviewed
Oct 21, 2022
liammulh
reviewed
Oct 21, 2022
liammulh
reviewed
Oct 21, 2022
|
Addition to the PR at Kate's request on Slack. |
|
I'm done with my review. Thanks for the changes, @gwhitney. |
katestange
reviewed
Oct 25, 2022
|
OK, have responded to all of your review comments. Let me know if anything else is needed for merge. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a new module
shared/maththat has some conveniencefunctions for math in frontscope, especially for working
with bigints.
Specifically this first revision has safeNumber, for
converting to a number with a check for loss of accuracy;
floorSqrt for finding a bigint square root; modulo for the
mathematician's modulo of bigints; and powmod for calculating
a power of a number to some modulus (much more efficiently than
exponentiating and then modding).
Also provides documentation and tests for the new features and
a guide to using bigints in frontscope.
Resolves #163.
Partially addresses #41.
Does the first half of #172.