-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Miscellaneous parameter improvements #538
Conversation
Not quite as simple as we estimated, but here it is. There is one thing about it on my mind though: really the drag handles is the only indication that the FORMULA entry boxes are different (and can be resized). But they are pretty subtle, though. Is it clear enough? Should we make some other styling difference for formulas, like a full box instead of an underline? Or should we make the drag handles more prominent? Unfortunately, there is no cross-browser way to CSS-style the drag handles, but you can overwrite them with your own graphic, although it's a little involved. |
Oh, probably the CI tests are going to fail. Presuming so, I will update the CI snapshots in the morning. |
I think it is clear enough visually! Everything is kinda small on the panes, it is of an appropriate relative size I think. |
Working on the resizing issue. But on a different point, did you switch the Wait For It featured specimen to formula mode just to get the two-tone color scheme with transparency? If so, should I just turn on transparency color picking for all color parameters and switch Wait For It back to List mode? I think it's much easier/clearer to see what is going on in list mode. Thanks for letting me know. |
You can still let me know, but actually I went ahead and did it, it was so easy. If you think it was not a good idea, I can back it out. Other than that point, this PR should be ready for final review. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome!
By submitting this PR, I am indicating to the Numberscope maintainers that I have read and understood the contributing guidelines and that this PR follows those guidelines to the best of my knowledge. I have also read the pull request checklist and followed the instructions therein.
This PR makes the following moderate improvements to the ParamEditor interface:
In addition, there was a bug in the handling of command-line arguments to the test: npm scripts such that all but the first were ignored. Now they are all respected, so that you can write, for example,
npm run test:e2e -- --update-snapshots idiot
if you know that the only changed snapshots were in the idiot test, so that it won't have to run all of the other tests just to get snapshots of those (and won't run the risk of accidentally updating a snapshot with an erroneous one if there happens to be a network error during one of the other tests, for example).