Skip to content

Commit

Permalink
Revert removing vue-tempate-compilation plugin, add vue dependency to…
Browse files Browse the repository at this point in the history
… playgound, to solve out-of-memory issues, while resolving vue alias.
  • Loading branch information
chakAs3 committed Dec 27, 2024
1 parent d8f4ca8 commit 314f1b1
Show file tree
Hide file tree
Showing 3 changed files with 19 additions and 10 deletions.
18 changes: 9 additions & 9 deletions packages/storybook-addon/src/preset.ts
Original file line number Diff line number Diff line change
Expand Up @@ -160,15 +160,15 @@ function mergeViteConfig(
}

// Remove the 'storybook:vue-template-compilation' plugin because it yields out-of-memory issues
const templatePluginIndex = plugins?.findIndex(
(plugin) =>
plugin &&
'name' in plugin &&
plugin.name === 'storybook:vue-template-compilation',
)
if (templatePluginIndex !== -1) {
plugins.splice(templatePluginIndex, 1)
}
// const templatePluginIndex = plugins?.findIndex(
// (plugin) =>
// plugin &&
// 'name' in plugin &&
// plugin.name === 'storybook:vue-template-compilation',
// )
// if (templatePluginIndex !== -1) {s
// plugins.splice(templatePluginIndex, 1)
// }
extendedConfig.plugins = plugins

// Storybook adds 'vue' as dependency that should be optimized, but nuxt explicitly excludes it from pre-bundling
Expand Down
1 change: 1 addition & 0 deletions playground/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -17,6 +17,7 @@
"@storybook/addon-interactions": "8.4.7",
"@storybook/addon-links": "8.4.7",
"nuxt": "3.14.1592",
"vue": "^3.3.4",
"storybook": "8.4.7",
"vite-plugin-inspect": "0.10.3"
}
Expand Down
10 changes: 9 additions & 1 deletion pnpm-lock.yaml

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

0 comments on commit 314f1b1

Please sign in to comment.