Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add DamageIncrease method overload to support DamageBonus parameter #774

Merged
merged 2 commits into from
Sep 9, 2024
Merged

Add DamageIncrease method overload to support DamageBonus parameter #774

merged 2 commits into from
Sep 9, 2024

Conversation

zeroark
Copy link
Contributor

@zeroark zeroark commented Aug 16, 2024

This should resolve issue #772

No modifications on existing API happens and since the Effect.Create has no Unit Tests I didn't add any.

@github-actions GitHub Actions
Copy link

github-actions bot commented Sep 9, 2024

Test Results

       1 files  ±0     135 suites  ±0   1m 20s ⏱️ ±0s
1 407 tests ±0  1 407 ✔️ ±0  0 💤 ±0  0 ❌ ±0 
2 138 runs  ±0  2 138 ✔️ ±0  0 💤 ±0  0 ❌ ±0 

Results for commit ec28eed. ± Comparison against base commit 40eb250.

jhett12321
jhett12321 approved these changes Sep 9, 2024
View reviewed changes
Copy link
Contributor

@jhett12321 jhett12321 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the fixed function :)

@jhett12321 jhett12321 merged commit f658a6e into nwn-dotnet:development Sep 9, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jhett12321 jhett12321 jhett12321 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@zeroark @jhett12321