NwCreature - Associates #795
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 17 commits
October 2, 2023 18:59
OnSpellBroadcast - Add Target & position parameters
NwAreaOfEffect - Add SetRadius
NwCreature - Add Setters for familiar and companions types and names
jhett12321
requested changes
Jan 4, 2025
Comment on lines
1024
to
1037
| public void ForceLevelUp(byte nClass, byte nHitDie, byte nAbilityGain = 6, int bEpic = 0, ushort nSkillPointsRemaining = 0, byte nDomain1 = 255, byte nDomain2 = 255, byte nSchool = 255, int addStatsToList = 1) | ||
| { | ||
| CNWLevelStats stats = new CNWLevelStats() | ||
| { | ||
| m_nClass = nClass, | ||
| m_nHitDie = nHitDie, | ||
| m_nAbilityGain = nAbilityGain, | ||
| m_bEpic = bEpic, | ||
| m_nSkillPointsRemaining = nSkillPointsRemaining, | ||
| }; | ||
|
|
||
| Creature.m_pStats.LevelUp(stats, nDomain1, nDomain2, nSchool, addStatsToList); | ||
| GC.SuppressFinalize(stats); | ||
| } |
There was a problem hiding this comment.
Anvil API functions should use wrapper classes and more friendly types when possible.
We do not prefix parameter names with the type.
Suggested change
| public void ForceLevelUp(byte nClass, byte nHitDie, byte nAbilityGain = 6, int bEpic = 0, ushort nSkillPointsRemaining = 0, byte nDomain1 = 255, byte nDomain2 = 255, byte nSchool = 255, int addStatsToList = 1) | |
| { | |
| CNWLevelStats stats = new CNWLevelStats() | |
| { | |
| m_nClass = nClass, | |
| m_nHitDie = nHitDie, | |
| m_nAbilityGain = nAbilityGain, | |
| m_bEpic = bEpic, | |
| m_nSkillPointsRemaining = nSkillPointsRemaining, | |
| }; | |
| Creature.m_pStats.LevelUp(stats, nDomain1, nDomain2, nSchool, addStatsToList); | |
| GC.SuppressFinalize(stats); | |
| } | |
| public void ForceLevelUp(NwClass classType, byte hitDie, Ability? abilityGain = default, bool epic = false, ushort skillPointsRemaining = 0, NwDomain? domain1 = default, NwDomain? domain2 = default, SpellSchool school = SpellSchool.Unknown, bool addStatsToList = true) | |
| { | |
| CNWLevelStats stats = new CNWLevelStats() | |
| { | |
| m_nClass = classType.Id, | |
| m_nHitDie = hitDie, | |
| m_nAbilityGain = abilityGain?.Value ?? 6, | |
| m_bEpic = epic.ToInt(), | |
| m_nSkillPointsRemaining = skillPointsRemaining, | |
| }; | |
| Creature.m_pStats.LevelUp(stats, nDomain1?.Id ?? 255, nDomain2?.Id ?? 255, (unchecked((byte)School), addStatsToList.ToInt()); | |
| GC.SuppressFinalize(stats); | |
| } |
Please update the comments with the parameter changes :)
Comment on lines
2569
to
2612
| /// Instructs this creature to summon their animal companion.<br/> | ||
| /// Instructs this creature to summon their animal companion. |
There was a problem hiding this comment.
This line break can be restored
Comment on lines
2667
to
2750
| for (int i = 1;; i++) | ||
| for (int i = 1; ; i++) |
There was a problem hiding this comment.
Please revert this change
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
jhett12321
approved these changes
Jan 20, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add methods to handle associates