Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mwalsh/FE-169 #77

Open
wants to merge 5 commits into
base: master
Choose a base branch
from
Open

Mwalsh/FE-169 #77

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
3a21bea
update README.md
walsh9 Feb 7, 2024
aebdc31
0.5.15
walsh9 Feb 7, 2024
9e378d3
fix for icons in social links component
walsh9 Dec 9, 2024
c3326e0
update changelog
walsh9 Dec 9, 2024
295859c
0.5.16
walsh9 Dec 9, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 8 additions & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,12 @@
# nypr-publisher-lib Changelog
## 0.5.16

- [BUGFIX] Update social-links component to use fontawesome styles instead of fa-icon svg component

## 0.5.15

- [ENHANCEMENT] Move transcript links to the right of staff only edit buttons

## 0.5.14

- [ENHANCEMENT] add transcript links to story teases
Expand Down
4 changes: 2 additions & 2 deletions addon/templates/components/social-links.hbs
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,13 +1,13 @@
{{#if facebook}}
<a href={{facebook.href}} target="_blank" class="social-links__btn">
{{fa-icon 'facebook'}}
<i class="fa fa-facebook"></i>
<span class="social-links__hidden">Share on Facebook</span>
</a>
{{/if}}

{{#if twitter}}
<a href={{twitter.href}} target="_blank" class="social-links__btn">
{{fa-icon 'twitter'}}
<i class="fa fa-twitter"></i>
<span class="social-links__hidden">Share on Twitter</span>
</a>
{{/if}}
Expand Down
4 changes: 3 additions & 1 deletion app/styles/nypr-publisher-lib/_social-links.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,9 @@
@include btn--circle;
@include btn--blacktext;
margin-right: 7px;
display: inline-block;
display: inline-flex;
align-items: center;
justify-content: center;
vertical-align: middle;

> i {
Expand Down
2 changes: 1 addition & 1 deletion package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"name": "nypr-publisher-lib",
"version": "0.5.14",
"version": "0.5.16",
"description": "NYPR publisher lib.",
"keywords": [
"ember-addon"
Expand Down