Skip to content

Commit

Permalink
Merge pull request #410 from nypublicradio/mwalsh/WQXR-229
Browse files Browse the repository at this point in the history
WQXR-229 Update ad units
  • Loading branch information
walsh9 authored Jun 1, 2022
2 parents 9133ce4 + 4c559b3 commit 23ae4cb
Show file tree
Hide file tree
Showing 9 changed files with 12 additions and 12 deletions.
2 changes: 1 addition & 1 deletion app/channel/template.hbs
Original file line number Diff line number Diff line change
Expand Up @@ -89,7 +89,7 @@

{{dfp-ad
slotClassNames="align--mq-centertoright channel-ad"
slot="/6483581/rectangle/wqxr_rectangle"
slot="/1007549/WQXR/wqxr_rectangle"
target="rightRail"
sizes=(array (array 300 250) (array 300 600))}}

Expand Down
2 changes: 1 addition & 1 deletion app/story/template.hbs
Original file line number Diff line number Diff line change
Expand Up @@ -172,7 +172,7 @@

{{dfp-ad
slotClassNames="align--mq-centertoright right-rail"
slot="/6483581/rectangle/wqxr_rectangle"
slot="/1007549/WQXR/wqxr_rectangle"
target="rightRail"
sizes=(array (array 300 250) (array 300 600))}}

Expand Down
2 changes: 1 addition & 1 deletion app/stream/template.hbs
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@
<div class="l-skinny">
{{dfp-ad
slotClassNames="align--mq-centertoright"
slot="/6483581/rectangle/wqxr_rectangle"
slot="/1007549/WQXR/wqxr_rectangle"
target="rightRail"
sizes=(array (array 300 250) (array 300 600))}}
</div>
Expand Down
4 changes: 2 additions & 2 deletions app/templates/application.hbs
Original file line number Diff line number Diff line change
Expand Up @@ -6,8 +6,8 @@
slotClassNames="leaderboard-ad dfp-ad"
slot=config.googleAdManagerAdspot
target="leaderboard_ad_home"
mapping=(array (array 0 (array 300 50)))
sizes=(array (array 300 50))
mapping=(array (array 0 (array 320 50)))
sizes=(array (array 320 50))
}}
{{else}}
{{dfp-ad
Expand Down
2 changes: 1 addition & 1 deletion cypress/fixtures/events.html
Original file line number Diff line number Diff line change
Expand Up @@ -295,7 +295,7 @@ <h4><a class="more" href="/events/archive/">Events Calendar</a></h4>
<div
data-ember-component="dfp-ad"
data-ember-args='{
"slot": "/6483581/rectangle/wqxr_rectangle",
"slot": "/1007549/WQXR/wqxr_rectangle",
"sizes": [[300, 250], [300, 600]],
"target": "wqxr_bigbox_ad",
"slotClassNames": "align--mq-centertoright right-rail"}'></div>
Expand Down
2 changes: 1 addition & 1 deletion cypress/fixtures/playlist-daily.html
Original file line number Diff line number Diff line change
Expand Up @@ -2668,7 +2668,7 @@ <h2 class="h2">
<div
data-ember-component="dfp-ad"
data-ember-args='{
"slot": "/6483581/rectangle/wqxr_rectangle",
"slot": "/1007549/WQXR/wqxr_rectangle",
"sizes": [[300, 250], [300, 600]],
"target": "wqxr_bigbox_ad",
"slotClassNames": "align--mq-centertoright right-rail"}'></div>
Expand Down
2 changes: 1 addition & 1 deletion cypress/fixtures/schedule.html
Original file line number Diff line number Diff line change
Expand Up @@ -549,7 +549,7 @@ <h2 class="h2">
<div
data-ember-component="dfp-ad"
data-ember-args='{
"slot": "/6483581/rectangle/wqxr_rectangle",
"slot": "/1007549/WQXR/wqxr_rectangle",
"sizes": [[300, 250], [300, 600]],
"target": "wqxr_bigbox_ad",
"slotClassNames": "align--mq-centertoright right-rail"}'></div>
Expand Down
2 changes: 1 addition & 1 deletion cypress/fixtures/videos.html
Original file line number Diff line number Diff line change
Expand Up @@ -539,7 +539,7 @@ <h3 class="title"><a href="http://www.wqxr.org/story/wqxr-best-studio-2018-villa
<div
data-ember-component="dfp-ad"
data-ember-args='{
"slot": "/6483581/rectangle/wqxr_rectangle",
"slot": "/1007549/WQXR/wqxr_rectangle",
"sizes": [[300, 250], [300, 600]],
"target": "wqxr_bigbox_ad",
"slotClassNames": "align--mq-centertoright right-rail"}'></div>
Expand Down
6 changes: 3 additions & 3 deletions mirage/helpers/django-html.js
Original file line number Diff line number Diff line change
Expand Up @@ -1083,12 +1083,12 @@ var HTML = `<html>
googletag.cmd.push(function() {
var leaderboard_mapping = googletag.sizeMapping()
.addSize([0, 0], [300, 50])
.addSize([0, 0], [320, 50])
.addSize([758, 0], [728, 90])
.addSize([1020, 0], [970, 415])
.build()
wnyc.ads.leaderboard = googletag.defineSlot("/6483581/leaderboard/wnyc_leaderboard", [[970, 415], [728, 90], [300, 50]], "leaderboard")
wnyc.ads.leaderboard = googletag.defineSlot("/6483581/leaderboard/wnyc_leaderboard", [[970, 415], [728, 90], [320, 50]], "leaderboard")
.defineSizeMapping(leaderboard_mapping)
.addService(googletag.pubads());
Expand All @@ -1100,7 +1100,7 @@ var HTML = `<html>
})
wnyc.ads["rightRail"] = googletag.defineSlot("/6483581/rectangle/wnyc_rectangle", [[300, 250], [300, 600]], "rightRail")
wnyc.ads["rightRail"] = googletag.defineSlot("/1007549/WQXR/wqxr_rectangle", [[300, 250], [300, 600]], "rightRail")
.addService(googletag.pubads());
Expand Down

0 comments on commit 23ae4cb

Please sign in to comment.