Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

New AutomatedNightlyTestSuite for ASV AR. #620

Draft
wants to merge 2 commits into
base: development
Choose a base branch
from
Draft

New AutomatedNightlyTestSuite for ASV AR. #620

wants to merge 2 commits into from
+136 −8

Conversation

jromnoa
Copy link
Contributor

@jromnoa jromnoa commented Apr 12, 2023

Changes:

  • Adds the new _AutomatedNightlyTestSuite_.bv.lua test file which targets specific reliable tests for use with ASV AR.
  • It also adds the ShaderReloadSoakTest to the _FullTestSuite_.bv.lua test file as requested in the original internal JIRA request (can't link here). The intent is that ShaderReloadSoakTest and MaterialHotReloadTest are not part of this new _AutomatedNightlyTestSuite_.bv.lua test file but remain as part of the _FullTestSuite_.bv.lua test file.

Some important notes about this PR:

  • Currently there is a blocker that prevents the merging of this code until it is fixed. This blocker is also causing our current ASV AR setup for the development branch to fail until it is fixed: Restore Standalone target #616
  • This will be taken out of Draft PR mode once that fix is merged and the stabilization branch its merged to is then merged to the development branch.
  • I did a pseudo test of this code by replacing the AtomSampleViewerStandalone.exe with AtomSampleViewer.GameLauncher.exe and it mostly worked, other than the CLI args. So, in theory, this code should run as expected once the issue with the AtomSampleViewerStandalone target is resolved.

@jromnoa
Adds the new __AutomatedNightlyTestSuite_.bv.lua test file that is us…
5079ef0 
…ed for selecting the tests to run in the main GPU test runs for AtomSampleViewerStandalone. It also fixes some small import errors and identifies the AtomSampleViewer project by its correct o3de-atom-sampleviewer project name instead.

Signed-off-by: NULL <jromnoa@amazon.com>
@jromnoa jromnoa added sig/graphics-audio priority/major Major priority. Work that should be handled after all blocking and critical work is done. labels Apr 12, 2023
@jromnoa jromnoa requested review from shirangj, smurly, NeilGitGud and a team April 12, 2023 20:17
@jromnoa jromnoa self-assigned this Apr 12, 2023
smurly
smurly reviewed Apr 12, 2023
View reviewed changes
Copy link
Contributor

@smurly smurly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

not seeing _AutomatedNightlyTestSuite_.bv.lua in the PR

@jromnoa
Add _AutomatedNightlyTestSuite_.bv.lua missing test file.
151e504 
Signed-off-by: NULL <jromnoa@amazon.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@smurly smurly smurly approved these changes

@NeilGitGud NeilGitGud NeilGitGud approved these changes

@rgba16f rgba16f rgba16f approved these changes

@shirangj shirangj Awaiting requested review from shirangj

Assignees

@jromnoa jromnoa

Labels
priority/major Major priority. Work that should be handled after all blocking and critical work is done. sig/graphics-audio
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@jromnoa @smurly @NeilGitGud @rgba16f