Document Spark version for Spark functions (facebookincubator#10677)

Summary: The semantics of certain Spark functions vary between versions. This PR documents the Spark version to match when implementing a Spark function. Pull Request resolved: facebookincubator#10677 Reviewed By: kagamiori Differential Revision: D60881999 Pulled By: xiaoxmeng fbshipit-source-id: 0bdf7d30c95003daeefea45339bb7a18aed5667a
oap-project · Aug 8, 2024 · 79129df · 79129df
1 parent ad1f393
commit 79129df
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 0 deletions.
diff --git a/CONTRIBUTING.md b/CONTRIBUTING.md
@@ -182,6 +182,7 @@ with a benchmark.
    * Describe the function semantics and edge cases clearly.
 
 3. Use Presto or Spark to check the function semantics. 
+   * When implementing a Spark function, check the function semantics using Spark 3.5 with ANSI OFF.
    * Try different edge cases to check whether the function returns null, or
    throws, etc. 
    * Make sure to replicate the exact semantics.

diff --git a/velox/docs/spark_functions.rst b/velox/docs/spark_functions.rst
@@ -2,6 +2,8 @@
 Spark Functions
 ***********************
 
+The semantics of Spark functions match Spark 3.5 with ANSI OFF.
+
 .. toctree::
     :maxdepth: 1