Feedback #46
Closed
Feedback #46
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
philippederyck
added a commit
to philippederyck/OAUTHWG-oauth-browser-based-apps
that referenced
this pull request
Apr 11, 2024
Added missing word as suggested in oauth-wg#46
|
Thank you for your feedback @0xandybarlow. I have incorporated the missing word in PR #45, which is pending anyway. The text about AEAD encryption does need to be improved, but this is already pending in issue #44. @aaronpk This PR can be closed, since both items are addressed/being tracked in an issue. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overall the spec reads very well, I didn't have trouble following.
I did spot a missing word perhaps? And also I was curious if there was a better way to describe the intent behind "Authenticated Encryption with Authenticated Data" statements - cipher? suite? algorithm? I couldn't decide on a better way - feel free to reject!
Great work!