remove enums

oboratav · Oct 31, 2020 · e7acdc1 · e7acdc1
1 parent 3ba818f
commit e7acdc1
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 13 deletions.
diff --git a/proxy.py b/proxy.py
@@ -8,7 +8,7 @@
 from zeep.helpers import serialize_object
 
 from reference import (ERRORS_CREATE_SHIPMENT, PROD_WSDL_URL, SUCCESSFUL,
-                       TEST_WSDL_URL, QueryShipmentIdentifier)
+                       TEST_WSDL_URL, IDENTIFIER_INVOICE_ID, IDENTIFIER_SHIPMENT_ID)
 from utilities import extract_credentials, parameter_as_list
 
 transport = Transport(cache=SqliteCache())
@@ -96,13 +96,12 @@ def on_get(self, req, resp):
                                         description="No identifier was provided")
 
         if shipment_id is not None:
-            identifier_type = QueryShipmentIdentifier.SHIPMENT_ID
             query_by_shipment_id = req.context["client"].service.queryShipment(
                 wsUserName=req.context["username"],
                 wsPassword=req.context["password"],
                 wsLanguage="TR", # Fixed value
                 keys=shipment_id,
-                keyType=identifier_type,
+                keyType=IDENTIFIER_SHIPMENT_ID,
                 addHistoricalData=add_historical_data,
                 onlyTracking=tracking_url_only,
             )
@@ -111,13 +110,12 @@ def on_get(self, req, resp):
                 response_content = serialize_object(query_by_shipment_id, target_cls=dict)
 
         if invoice_id is not None:
-            identifier_type = QueryShipmentIdentifier.INVOICE_ID
             query_by_invoice_id = req.context["client"].service.queryShipment(
                 wsUserName=req.context["username"],
                 wsPassword=req.context["password"],
                 wsLanguage="TR", # Fixed value
                 keys=invoice_id,
-                keyType=identifier_type,
+                keyType=IDENTIFIER_INVOICE_ID,
                 addHistoricalData=add_historical_data,
                 onlyTracking=tracking_url_only,
             )

diff --git a/reference.py b/reference.py
@@ -1,5 +1,3 @@
-from enum import Enum
-
 import falcon
 
 # WSDL URLs
@@ -134,13 +132,11 @@
     ),
 }
 
-class QueryShipmentIdentifier(Enum):
-    SHIPMENT_ID = 0
-    INVOICE_ID = 1
+IDENTIFIER_SHIPMENT_ID = 0
+IDENTIFIER_INVOICE_ID = 1
 
-class CODPaymentMethod(Enum):
-    CASH = 0
-    CREDIT_CARD = 1
+COD_PAYMENT_METHOD_CASH = 0
+COD_PAYMENT_METHOD_CREDIT_CARD = 1
 
 class CallResult(object):
     def __init__(self, outFlag: str, successful: bool):