Skip to content

Commit

Permalink
feat: Boost default resources and support configuring healthcheck pro…
Browse files Browse the repository at this point in the history
…bes (#81)

* boost default cpu and memory limit / request

* support configuring healthchecks using values file

* nest probes under 'health' key

* bump chart version
  • Loading branch information
jsirianni authored Feb 6, 2024
1 parent 4d360bf commit 53497d9
Show file tree
Hide file tree
Showing 4 changed files with 37 additions and 17 deletions.
2 changes: 1 addition & 1 deletion charts/bindplane/Chart.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@ name: bindplane
description: BindPlane OP is an open source observability pipeline.
type: application
# The chart's version
version: 1.1.5
version: 1.1.6
# The BindPlane OP tagged release. If the user does not
# set the `image.tag` values option, this version is used.
appVersion: 1.42.0
Expand Down
9 changes: 6 additions & 3 deletions charts/bindplane/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -89,6 +89,9 @@ BindPlane OP is an open source observability pipeline.
| eventbus.pubsub.projectid | string | `""` | |
| eventbus.pubsub.topic | string | `""` | |
| eventbus.type | string | `""` | |
| health.livenessProbe | object | `{"httpGet":{"path":"/health","port":"http"}}` | Full configuration for livenessProbe. Supports all options documented here: https://kubernetes.io/docs/tasks/configure-pod-container/configure-liveness-readiness-startup-probes/. |
| health.readinessProbe | object | `{"httpGet":{"path":"/health","port":"http"}}` | Full configuration for readinessProbe. Supports all options documented here: https://kubernetes.io/docs/tasks/configure-pod-container/configure-liveness-readiness-startup-probes/. |
| health.startupProbe | object | `{"httpGet":{"path":"/health","port":"http"}}` | Full configuration for startupProbe. Supports all options documented here: https://kubernetes.io/docs/tasks/configure-pod-container/configure-liveness-readiness-startup-probes/. |
| image.name | string | `""` | Image name to be used. Defaults to `ghcr.io/observiq/bindplane-ee`. |
| image.tag | string | `""` | Image tag to use. Defaults to the version defined in the Chart's release. |
| ingress.annotations | object | `{}` | Custom annotations which will be added to the ingress object. Useful for specifying things such as `cert-manager.io/cluster-issuer`. |
Expand Down Expand Up @@ -121,9 +124,9 @@ BindPlane OP is an open source observability pipeline.
| prometheus.tls.secret.crtSubPath | string | `""` | The secret's subPath which contains the client certificate, required for mutual TLS. |
| prometheus.tls.secret.keySubPath | string | `""` | The secret's subPath which contains the client private key, required for mutual TLS. |
| prometheus.tls.secret.name | string | `""` | Kubernetes TLS secret name that contains the Prometheus TLS certificate(s). |
| resources.limits.memory | string | `"500Mi"` | Memory limit. |
| resources.requests.cpu | string | `"250m"` | CPU request. |
| resources.requests.memory | string | `"250Mi"` | Memory request. |
| resources.limits.memory | string | `"1000Mi"` | Memory limit. |
| resources.requests.cpu | string | `"1000m"` | CPU request. |
| resources.requests.memory | string | `"1000Mi"` | Memory request. |
| trace.otlp.endpoint | string | `""` | Endpoint of the OTLP trace receiver. Should be in the form of ip:port or host:port. |
| trace.otlp.insecure | bool | `false` | Set to `true` to disable TLS. Set to false if TLS is in use by the OTLP trace receiver. |
| trace.type | string | `""` | Trace type to use. Valid options include `otlp`. |
Expand Down
18 changes: 9 additions & 9 deletions charts/bindplane/templates/bindplane.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -292,18 +292,18 @@ spec:
resources:
{{- toYaml . | nindent 12 }}
{{- end }}
{{- with .Values.health.startupProbe }}
startupProbe:
httpGet:
path: /health
port: http
{{- toYaml . | nindent 12 }}
{{- end }}
{{- with .Values.health.readinessProbe }}
readinessProbe:
httpGet:
path: /health
port: http
{{- toYaml . | nindent 12 }}
{{- end }}
{{- with .Values.health.livenessProbe }}
livenessProbe:
httpGet:
path: /health
port: http
{{- toYaml . | nindent 12 }}
{{- end }}
{{- with .Values.containerSecurityContext }}
securityContext:
{{- toYaml . | nindent 12 }}
Expand Down
25 changes: 21 additions & 4 deletions charts/bindplane/values.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -272,14 +272,31 @@ config:
resources:
requests:
# -- Memory request.
memory: 250Mi
memory: 1000Mi
# -- CPU request.
cpu: 250m
cpu: 1000m
limits:
# -- Memory limit.
memory: 500Mi
memory: 1000Mi
# Disable cpu limit by default, for burstable qos class
# cpu: 500m
# cpu: 1000m

health:
# -- Full configuration for startupProbe. Supports all options documented here: https://kubernetes.io/docs/tasks/configure-pod-container/configure-liveness-readiness-startup-probes/.
startupProbe:
httpGet:
path: /health
port: http
# -- Full configuration for readinessProbe. Supports all options documented here: https://kubernetes.io/docs/tasks/configure-pod-container/configure-liveness-readiness-startup-probes/.
readinessProbe:
httpGet:
path: /health
port: http
# -- Full configuration for livenessProbe. Supports all options documented here: https://kubernetes.io/docs/tasks/configure-pod-container/configure-liveness-readiness-startup-probes/.
livenessProbe:
httpGet:
path: /health
port: http

ingress:
# -- Whether or not to enable ingress.
Expand Down

0 comments on commit 53497d9

Please sign in to comment.