feat(secret): Support reading the license key from secret #95
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jsirianni
commented
Mar 12, 2024
| @@ -51,6 +51,11 @@ jobs: | |||
| sleep 30 | |||
| kubectl -n ingress-nginx get all | |||
|
|
|||
| - name: Create secret | |||
There was a problem hiding this comment.
The test suite uses the values files in test/cases/. Instead of hardcoding a license there, we can create the "bindplane" secret with only the license key. I added a license to the repo's secrets.
jsirianni
commented
Mar 12, 2024
| @@ -6,6 +6,7 @@ config: | |||
| sessions_secret: 4484766F-5016-4077-B8E0-0DE1D637854B | |||
| server_url: http://bindplane.local:3001 | |||
| remote_url: ws://bindplane.local:3001 | |||
| licenseUseSecret: true | |||
There was a problem hiding this comment.
This test case will mount the license from the secret created in the CI workflow.
jsirianni
requested review from
andykellr and
dpaasman00
and removed request for
dpaasman00
andykellr
previously approved these changes
Mar 13, 2024
jsirianni
force-pushed
the
secret/license
branch
from
65b3a67 to
4510e02
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Changes
Added a new option,
config.licenseUseSecret. When true, the license will be read from the "bindplane" secret. This option is only considered ifconfig.licenseis not set. If both options are not set, the license will not be set in the environment (this is the existing behavior).Please check that the PR fulfills these requirements