Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dev DESCRIPTION PR fix #193

Merged
merged 4 commits into from
Jan 5, 2024
Merged

Conversation

mhpob
Copy link
Contributor

@mhpob mhpob commented Jan 5, 2024

Adding back in the changes I accidentally undid when addressing the merge conflict in c3ae7e2.

  • Add dplyr to Imports
  • Remove plyr from Imports

@mhpob mhpob changed the title Dev patch dependency dev DESCRIPTION PR fix Jan 5, 2024
@jdpye
Copy link
Member

jdpye commented Jan 5, 2024

I was about to dig into where and how we use sp, it looks like the changeover from greatLakesPoly to great_lakes_poly needs to happen in a few of the vignettes and handouts but nothing in actual package code is implicated. I think we lose sp and fix the vignettes, and possibly in that order.

@mhpob
Copy link
Contributor Author

mhpob commented Jan 5, 2024

I opened #194 for discussion. I removed the sp issue from this PR since it involves some bigger conceptual changes like you've outlined.

@jdpye
Copy link
Member

jdpye commented Jan 5, 2024

yeah, I think between this PR and #192 we are most of the way home on removing sp

@jdpye jdpye merged commit 4046f5d into ocean-tracking-network:dev Jan 5, 2024
0 of 5 checks passed
@mhpob mhpob deleted the dev-patch-dependency branch January 5, 2024 23:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants