Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fewer explicit tidyverse dependencies #230

Merged
merged 5 commits into from
Aug 15, 2024

Conversation

mhpob
Copy link
Contributor

@mhpob mhpob commented May 13, 2024

This PR removes tibble, magrittr, and tidyr from Imports, further reducing explicit dependencies as requested in #122. Note that glatos still depends on these packages due to dependency on dplyr ("reverse dependency").

glatos depends on dplyr for much of its coding. The functions from tibble and magrittr used by glatos are imported by dplyr; the functions can thus be called via dplyr:: and removed from glatos's Imports.

tidyr is used in one place by one function (read_otn_deployments) to pull yyyy-mm-dd dates from messy inputs. This was replaced using base:sub and a regex capture group. The example of read_otn_deployments results in identical objects.

Current R CMD check failure is due to a floating point issue on macOS which will be fixed with acceptance of #228

@chrisholbrook chrisholbrook merged commit 34eecfd into ocean-tracking-network:dev Aug 15, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants