Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add ALLOWED_VALIDATORS_LIST #829

Merged
merged 9 commits into from
Feb 12, 2025
Merged

add ALLOWED_VALIDATORS_LIST #829

merged 9 commits into from
Feb 12, 2025

Conversation

paulo-ocean
Copy link
Contributor

Fixes #813

Changes proposed in this PR:

  • Add ALLOWED_VALIDATORS_LIST, using access lists (who can validate assets before indexing)

@paulo-ocean paulo-ocean changed the title start add ALLOWED_VALIDATORS_LIST add ALLOWED_VALIDATORS_LIST Feb 3, 2025
@paulo-ocean paulo-ocean self-assigned this Feb 3, 2025
@paulo-ocean paulo-ocean marked this pull request as ready for review February 7, 2025 10:23
mariacarmina
mariacarmina reviewed Feb 10, 2025
View reviewed changes
Copy link
Member

@mariacarmina mariacarmina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

some comments on my side.

src/components/Indexer/utils.ts Show resolved Hide resolved
src/components/Indexer/utils.ts Show resolved Hide resolved
mariacarmina
mariacarmina reviewed Feb 10, 2025
View reviewed changes
Copy link
Member

@mariacarmina mariacarmina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we have some simple tests as well?

@paulo-ocean
Copy link
Contributor Author

paulo-ocean commented Feb 10, 2025 •
edited
Loading

Can we have some simple tests as well?

there are some tests on this PR (which is blocking others btw)
#826
and these are pretty much always the same checks.. once that is approved and merged i can refactor and extend the test, there is no point in repeating the same thing for 5 or 6 different variables, if the behavior is always the same

mariacarmina
mariacarmina approved these changes Feb 11, 2025
View reviewed changes
Copy link
Member

@mariacarmina mariacarmina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

jamiehewitt15
jamiehewitt15 approved these changes Feb 11, 2025
View reviewed changes
Copy link
Member

@jamiehewitt15 jamiehewitt15 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me

@paulo-ocean paulo-ocean merged commit 4f788cf into main Feb 12, 2025
12 checks passed
@paulo-ocean paulo-ocean deleted the issue-813-validators-list branch February 12, 2025 09:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jamiehewitt15 jamiehewitt15 jamiehewitt15 approved these changes

@mariacarmina mariacarmina mariacarmina approved these changes

@alexcos20 alexcos20 Awaiting requested review from alexcos20 alexcos20 is a code owner

@bogdanfazakas bogdanfazakas Awaiting requested review from bogdanfazakas bogdanfazakas is a code owner

Assignees

@paulo-ocean paulo-ocean

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Config env ALLOWED_VALIDATORS_LIST
3 participants
@paulo-ocean @jamiehewitt15 @mariacarmina