Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve on last used function #163

Merged
merged 4 commits into from
Mar 11, 2019
Merged

Improve on last used function #163

merged 4 commits into from
Mar 11, 2019

Conversation

TonyLianLong
Copy link
Member

This continues the PR #159 because Abizer has made useful suggestions to last_used.

Copy link
Member

@abizer abizer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good work, this addresses most of my earlier comments. a few more fixes and this should be ready to ship!

ocflib/lab/stats.py Outdated Show resolved Hide resolved
ocflib/lab/stats.py Show resolved Hide resolved
ocflib/lab/stats.py Show resolved Hide resolved
@abizer abizer merged commit c13cb0f into ocf:master Mar 11, 2019
@TonyLianLong TonyLianLong deleted the last_used branch March 11, 2019 02:29
ja5087 pushed a commit to ja5087/ocflib that referenced this pull request Apr 21, 2019
* Add domain_from_hostname to infra.hosts

* Improve on last_used

* Not calling domain_from_hostname within last_used

* Fix the variable name
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants