Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Complete Officers Page #198

Closed
jyxzhang opened this issue Mar 23, 2021 · 2 comments · Fixed by #253
Closed

Complete Officers Page #198

jyxzhang opened this issue Mar 23, 2021 · 2 comments · Fixed by #253
Labels
good first issue Good for newcomers

Comments

@jyxzhang
Copy link
Contributor

The officer's page still needs some place for the past officers. It could be a separate page, or could be like a dropdown at the bottom of the officer page. Also, all the officers are hardcoded right in the code. We should probably read the information from a file. On the old website, the contents are read from here, but I feel like since we aren't using Python and Django anymore, we should probably move to a different type of storage. The images for the officers will also need some file/folder setup.

@BernardZhao BernardZhao added the good first issue Good for newcomers label Mar 23, 2021
@BernardZhao
Copy link
Member

The images can be stored where the other images are stored and the contents can also be hardcoded, since it also is in existing ocfweb.

@bentref
Copy link
Contributor

bentref commented Nov 2, 2021

Closed by above PR ^

@bentref bentref closed this as completed Nov 2, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants