Implemented officers-page#198, yet again #253
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bentref
approved these changes
Oct 12, 2021
There was a problem hiding this comment.
'Twas quite a journey, so glad to see this ready to merge!
One suggestion: Would it make more sense to have each semester dropdown collapsed by default? Otherwise the dropdown functionality is unlikely to be ever used--you wouldn't go through and manually collapse a bunch
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I had previously implemented this feature in #205, but Jenkins decided it would have none of it. Now 4 months after, we've both grown a considerable amount, and have learned to put our differences aside for the good of the OCF and World Peace™.
This is the result:
This is addressing issue #198.
I created a json file in the assets folder with all the past officers data. I then parse that file in
Officers.vueto construct it into a table inside a dropdown.The good thing of this approach is that it's not hard coded and updating past officers will simply need an edit to the json file.
I look forward to pushing this merge together.