Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add full_name to ldap_person and broaden dictionary definition #1341

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Add full_name to ldap_person and broaden dictionary definition #1341

wants to merge 3 commits into from

Conversation

mikeradka
Copy link
Contributor

@mikeradka mikeradka commented Feb 6, 2025 •
edited
Loading

Related Issue: N/A

Description of changes:

This PR:

  • Adds the full_name attribute to the ldap_person object.
  • Relaxes the description of the full_name attribute so it can be used with a broader range of products, technologies, and implementations. In the attribute dictionary, the See specific usage. convention is applied.
image image image

@mikeradka
Relax the description of full_name.
c4e097c 
Signed-off-by: Michael Radka <mradka@splunk.com>
@mikeradka mikeradka added enhancement New feature or request grammar_consistency Issues related to the attribute grammar consistency work-stream non_breaking Non Breaking, backwards compatible changes labels Feb 6, 2025
@mikeradka mikeradka self-assigned this Feb 6, 2025
@pagbabian-splunk
Copy link
Contributor

Thanks @mikeradka - as we discussed in Slack, I would also add full_name to ldap_person with the original description, so it doesn't get lost for when it is more appropriate.

@mikeradka mikeradka marked this pull request as draft February 6, 2025 16:56
@mikeradka
Add full_name attribute to the ldap_person object
3e105a9 
Signed-off-by: Michael Radka <mradka@splunk.com>
@mikeradka
Add 1341 to CHANGELOG
c0f99c2 
Signed-off-by: Michael Radka <mradka@splunk.com>
@mikeradka mikeradka marked this pull request as ready for review February 6, 2025 17:07
@mikeradka
Copy link
Contributor Author

Thanks @mikeradka - as we discussed in Slack, I would also add full_name to ldap_person with the original description, so it doesn't get lost for when it is more appropriate.

Great suggestion, Paul. I've went ahead and added full_name to ldap_person with the original (LDAP CN) description. Please re-review.

@mikeradka mikeradka changed the title Relax the description of full_name. Add full_name to ldap_person and broaden dictionary definition Feb 6, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@floydtree floydtree floydtree approved these changes

@pagbabian-splunk pagbabian-splunk Awaiting requested review from pagbabian-splunk pagbabian-splunk is a code owner

@Aniak5 Aniak5 Awaiting requested review from Aniak5 Aniak5 is a code owner

@zschmerber zschmerber Awaiting requested review from zschmerber zschmerber is a code owner

@jonrau-at-queryai jonrau-at-queryai Awaiting requested review from jonrau-at-queryai jonrau-at-queryai is a code owner

@davemcatcisco davemcatcisco Awaiting requested review from davemcatcisco davemcatcisco is a code owner

At least 3 approving reviews are required to merge this pull request.

Assignees

@mikeradka mikeradka

Labels
enhancement New feature or request grammar_consistency Issues related to the attribute grammar consistency work-stream non_breaking Non Breaking, backwards compatible changes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mikeradka @pagbabian-splunk @floydtree