network interface description #1344
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Edit dictionary for physical and virtual network interfaces Signed-off-by: Jason Reimer <12201402+jasonbreimer@users.noreply.github.com>
update object network_interface for physical or virtual Signed-off-by: Jason Reimer <12201402+jasonbreimer@users.noreply.github.com>
Updates for network interface(s) for virtual or physical Signed-off-by: Jason Reimer <12201402+jasonbreimer@users.noreply.github.com>
jasonbreimer
added
description_updates
jasonbreimer
requested review from
floydtree,
pagbabian-splunk,
Aniak5,
mikeradka,
zschmerber,
jonrau-at-queryai and
davemcatcisco
as code owners
floydtree
requested changes
Feb 10, 2025
Description changes unnecessary in changelog. Signed-off-by: Jason Reimer <12201402+jasonbreimer@users.noreply.github.com>
floydtree
approved these changes
Feb 11, 2025
jonrau-at-queryai
approved these changes
Feb 11, 2025
Aniak5
approved these changes
Feb 11, 2025
mikeradka
approved these changes
Feb 11, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes:
Update Dictionary description for network interfaces to reference "physical or virtual"
Update network interface object description to reference "physical or virtual"
Update changelog to reference above.