Allow retrieving only warm water profile #74
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The 'Black' code style error in tools.py is unrelated to my PRs, but I nevertheless fixed it in #72. I need to look into how to fix the coverage issue... |
|
The new test was 99% written by GitHub Copilot. But the style seems to fit the other tests and it fixed the coverall issue. However, it could be argued that I put the new test class in the wrong file. At this point I need direction from a reviewer. Once #72 is merged, all checks will pass. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I added a new argument to
HeatBuilding():This causes only the warm water profile to be returned, by setting the sigmoid parameters a, b and c to 0 and only keeping parameter d.
Fixes #73
Fixes #59