prov/tcp: Only disable ep if the failure can not be retried #10779
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@shefty are you ok with the patch? We saw some failures on our site "ofi_bsock_async_done() Error reading MSG_ERRQUEUE (Resource temporarily unavailable)" If this means EAGAIN, then ep should not be disabled? |
shefty
requested changes
Feb 10, 2025
ah, sure. thanks! @shefty |
shefty
reviewed
Feb 10, 2025
src/common.c
Outdated
| @@ -1421,6 +1421,9 @@ int ofi_bsock_async_done(const struct fi_provider *prov, | |||
| msg.msg_controllen = sizeof(ctrl); | |||
| ret = recvmsg(bsock->sock, &msg, MSG_ERRQUEUE); | |||
| if (ret < 0) { | |||
| if (OFI_SOCK_TRY_SND_RCV_AGAIN(ret)) | |||
There was a problem hiding this comment.
This is a direct call to recvmsg, so you want to use errno instead of ret. This ends up being linux specific code.
|
Final changes look okay, but please squash the commits |
Only disable ep if the failure can not be retried. Signed-off-by: Di Wang <ddiwang@google.com>
sure. thanks |
shefty
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Only disable ep if the failure can not be retried.