Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for returning tokens while using MFA Attestation #191

Merged
merged 1 commit into from
May 14, 2024

Conversation

mikenachbaur-okta
Copy link
Contributor

No description provided.

Copy link

@jaredperreault-okta jaredperreault-okta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@@ -0,0 +1,7 @@
{
"token_type": "Bearer",

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: Does Bearer make sense in this context? Might be good feedback for the backend team

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah that's a good point.

@mikenachbaur-okta mikenachbaur-okta merged commit 1a533d8 into master May 14, 2024
8 checks passed
@mikenachbaur-okta mikenachbaur-okta deleted the OKTA-663114-MFAAttestation branch May 14, 2024 23:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants