API request usability and stability improvements #202
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This improves how APIRequest arguments are handled, and ensures type safety for the `bodyParameters` arguments. This improves the cleanliness of unit tests, ensures the types can be properly normalized when merging values from different software components, and pushes conversion of API request values down to the lowest level.
rajdeepnanua-okta
approved these changes
Jul 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The APIClient system forms the foundation for most everything within the Client SDK, and as such the types and handling of data sent using these classes and protocols is of the utmost importance. To that end, this PR introduces several enhancements that will improve APIClient for future changes.
APIRequestArgumentinstead ofAnyto improve how arguments are handled, tested, and validated.APIRequestArgumentconformances to several key types, includingJWT,GrantType, andToken.Kind.APIRequestArgumentvalue conversion for types that already conform toRawRepresentablewith aStringvalue type.SDKVersion.registeris thread-safe, and begin initial adoption of theSendableprotocol.