-
Notifications
You must be signed in to change notification settings - Fork 20
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update minimum Swift, Xcode, and platform versions #207
Conversation
Unfortunately git didn't detect the move from |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What does our testing look like for linux and visionOS?
if strcmp(objCType, "f") == 0 || | ||
strcmp(objCType, "d") == 0 | ||
{ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
interesting, how sure are you that this will work permanently?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This has been around within Objective-C since the dawn of time, so it's unlikely to change. I would use the @encode
feature, but that's not available in Swift, so it was more straightforward to use the string equivalents.
@stevelind-okta Linux testing is currently limited to running To date we haven't really had any matrix / legacy version testing as part of the CI process, so this PR is the first to introduce parallel unit tests against different OS platforms and versions. I'm considering doing the same for our E2E UI tests, but I'd capture that as a separate story. |
As per this SDK's support policy, this updates the minimum supported version of Xcode to 15, and as a result updates the supported version of Swift to 5.9, and the minimum supported platform versions.
Furthermore, this update reintroduces experimental support on Linux.