Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update minimum Swift, Xcode, and platform versions #207

Merged
merged 20 commits into from
Aug 16, 2024

Conversation

mikenachbaur-okta
Copy link
Contributor

As per this SDK's support policy, this updates the minimum supported version of Xcode to 15, and as a result updates the supported version of Swift to 5.9, and the minimum supported platform versions.

Furthermore, this update reintroduces experimental support on Linux.

@mikenachbaur-okta
Copy link
Contributor Author

Unfortunately git didn't detect the move from UnsafeLock.swift to Lock.swift, so it's showing up as a deletion/add. 🤷🏼‍♀️

Copy link

@stevelind-okta stevelind-okta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What does our testing look like for linux and visionOS?

Comment on lines +254 to +256
if strcmp(objCType, "f") == 0 ||
strcmp(objCType, "d") == 0
{

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

interesting, how sure are you that this will work permanently?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

https://developer.apple.com/library/archive/documentation/Cocoa/Conceptual/ObjCRuntimeGuide/Articles/ocrtTypeEncodings.html

This has been around within Objective-C since the dawn of time, so it's unlikely to change. I would use the @encode feature, but that's not available in Swift, so it was more straightforward to use the string equivalents.

@mikenachbaur-okta
Copy link
Contributor Author

@stevelind-okta Linux testing is currently limited to running swift test on ubuntu-latest, but no E2E automated test flows (yet). visionOS is being tested with Xcode automated tests against visionOS 1.0, but no E2E flows right now either.

To date we haven't really had any matrix / legacy version testing as part of the CI process, so this PR is the first to introduce parallel unit tests against different OS platforms and versions. I'm considering doing the same for our E2E UI tests, but I'd capture that as a separate story.

@mikenachbaur-okta mikenachbaur-okta merged commit 34ca926 into master Aug 16, 2024
16 checks passed
@mikenachbaur-okta mikenachbaur-okta deleted the OKTA-791856-MinVersions branch August 16, 2024 20:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants