Fix linked resources interface #2173
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zerocrates
reviewed
Apr 18, 2024
| // The shared label is translatable if at least one of the individual | ||
| // labels is a property label. A shared label is not translatable if | ||
| // all the individual labels are alternate labels. | ||
| if (isset($results[$result['property_id']][$label]['label_is_translatable'])) { |
There was a problem hiding this comment.
I think it might be a little clearer/simpler to do it like this:
if ($labelIsTranslatable) {
$results[$result['property_id']][$label]['label_is_translatable'] = true;
}
to replace all of what's up here, and then down when building $subjectValueProperties below do
'label_is_translatable' => $data['label_is_translatable'] ?? false,
So you only ever set label_is_translatable to the $results if it's true, then if it's missing (so it was never true for that shared label) you just mark it false when returning. And then you don't have to be checking if the flag is already set for the current label every time through the loop.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an attempt to fix the linked resources resource page block, specifically the redundant select options and inconsistency between the select menu and the results.