Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(deps): update dependency cmdk to v1 #30

Merged
merged 3 commits into from
Oct 21, 2024
Merged

fix(deps): update dependency cmdk to v1 #30

merged 3 commits into from
Oct 21, 2024

Conversation

omeralpi
Copy link
Owner

fixes #29

@omeralpi omeralpi linked an issue May 21, 2024 that may be closed by this pull request
Is there a future update to be compatible with cmdk v1.0.0? #29
Closed
@vercel Vercel
Copy link

vercel bot commented May 21, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
shadcn-phone-input ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 21, 2024 5:34pm

@omeralpi omeralpi mentioned this pull request May 21, 2024
Closed
@Husain010
Copy link

Great, once merged please let me know! It's a great component!

@cjxe
Copy link

cjxe commented May 31, 2024

Hi @omeralpi, what is blocking from merging this PR?

@omeralpi
Copy link
Owner Author

omeralpi commented May 31, 2024 •
edited
Loading

Hi @omeralpi, what is blocking from merging this PR?

I hope that the upgrade of the cmdk package by shadcn will happen soon. Anyone who wishes can use this PR for now.

shadcn-ui/ui#3872
shadcn-ui/ui#3769
https://github.com/shadcn-ui/ui/blob/main/apps/www/package.json#L58

@omeralpi omeralpi force-pushed the main branch 3 times, most recently from 59b8624 to 1256597 Compare August 24, 2024 22:10
@bobbonius
Copy link

Hi @omeralpi, what is blocking from merging this PR?

I hope that the upgrade of the cmdk package by shadcn will happen soon. Anyone who wishes can use this PR for now.

shadcn-ui/ui#3872 shadcn-ui/ui#3769 https://github.com/shadcn-ui/ui/blob/main/apps/www/package.json#L58

Hi @omeralpi Looks like that happened right? So would be nice to update here as well. Thanks for the nice component :)

@omeralpi omeralpi merged commit 0484cf1 into main Oct 21, 2024
3 checks passed
@omeralpi omeralpi mentioned this pull request Oct 21, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Is there a future update to be compatible with cmdk v1.0.0?
4 participants
@omeralpi @Husain010 @cjxe @bobbonius