Calculate entropy #199
Merged
Calculate entropy #199
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nerd alert ! 🤓 |
|
I've been playing with plotext on this branch and I honestly love this ❤️ |
vlaci
reviewed
Jan 26, 2022
kukovecz
reviewed
Jan 26, 2022
kissgyorgy
force-pushed
the
calculate-entropy
branch
from
e331e92 to
52c66af
Compare
kukovecz
approved these changes
Jan 27, 2022
kukovecz
force-pushed
the
calculate-entropy
branch
from
52c66af to
ecb5f91
Compare
Validate the specified value starting from 1. (0 makes no sense, because it would mean don't do anything).
We calculate entropy percenteges in 1mB chunks. We tested with different chunk sizes and the bigger the chunk size was the faster it could calculate 1mB seemed like a sweet spot, which isn't too small to be too slow, but granular enough to provide useful information about most binary files. There is a new CLI option: --entropy-depth, which determines how deep we should calculate entropy for these files. The 0 value can turn this feature completely off.
For entropy representation
A graphical plot is shown in ASCII when verbose mode is enabled. We are using plotext for the drawing.
Explained by QKaiser: This will provide more granularity for users looking into small files (e.g.encrypted config file), but keep a "constant" time regardless of the file being analyzed.
Iterators should have no side effects, because calling them would be very suprising (nothing would happen if the iterator is not exhausted).
kukovecz
force-pushed
the
calculate-entropy
branch
from
ecb5f91 to
7b1c18e
Compare
qkaiser
approved these changes
Jan 27, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Calculate entropy for all
UnknownChunks and draw an ASCII text plot on verbose mode.Fixes #70