style(theme): change onBackground to onSurface for pop-up menu buttons

onestudio-co · Jul 27, 2024 · 244dd2f · 244dd2f
1 parent 46e80c7
commit 244dd2f
Show file tree

Hide file tree

Showing 3 changed files with 4 additions and 8 deletions.
diff --git a/lib/core/theme/app_dark_theme_data.dart b/lib/core/theme/app_dark_theme_data.dart
@@ -8,12 +8,10 @@ ThemeData appDarkThemeData() {
       primary: Color.fromRGBO(50, 45, 120, 1),
       secondary: Color.fromRGBO(34, 193, 224, 1),
       surface: Colors.white54,
-      background: Colors.white54,
       error: Color.fromRGBO(241, 95, 109, 1),
       onPrimary: Colors.white,
       onSecondary: Colors.white,
       onSurface: Colors.white,
-      onBackground: Colors.white,
       onError: Colors.white,
       brightness: Brightness.dark,
     ),

diff --git a/lib/core/theme/app_light_theme_data.dart b/lib/core/theme/app_light_theme_data.dart
@@ -8,12 +8,10 @@ ThemeData appLightThemeData() {
       primary: Color.fromRGBO(50, 45, 120, 1),
       secondary: Color.fromRGBO(34, 193, 224, 1),
       surface: Colors.black,
-      background: Colors.black,
       error: Color.fromRGBO(241, 95, 109, 1),
       onPrimary: Colors.black,
       onSecondary: Colors.black,
       onSurface: Colors.black,
-      onBackground: Colors.black,
       onError: Colors.black,
       brightness: Brightness.light,
     ),

diff --git a/lib/core/widgets/bond_pop_menu/bond_pop_menu_button.dart b/lib/core/widgets/bond_pop_menu/bond_pop_menu_button.dart
@@ -23,23 +23,23 @@ class BondPopMenuButton extends ConsumerWidget {
           value: Menu.theme,
           icon: Icon(
             Icons.color_lens_rounded,
-            color: context.colorScheme.onBackground,
+            color: context.colorScheme.onSurface,
           ),
           title: context.localizations.popup_menu_theme,
         ),
         BondPopupBondMenuItem(
           value: Menu.language,
           icon: Icon(
             Icons.language,
-            color: context.colorScheme.onBackground,
+            color: context.colorScheme.onSurface,
           ),
           title: context.localizations.popup_menu_language_title,
         ),
         BondPopupBondMenuItem(
           value: Menu.notifications,
           icon: Icon(
             Icons.notifications_rounded,
-            color: context.colorScheme.onBackground,
+            color: context.colorScheme.onSurface,
           ),
           title: context.localizations.popup_menu_notification_center,
         ),
@@ -48,7 +48,7 @@ class BondPopMenuButton extends ConsumerWidget {
             value: Menu.logout,
             icon: Icon(
               Icons.logout,
-              color: context.colorScheme.onBackground,
+              color: context.colorScheme.onSurface,
             ),
             title: context.localizations.popup_menu_logout,
           ),