vaults: gov active-collateral #20
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ThanhNhann
reviewed
Sep 30, 2024
|
|
||
| option go_package = "github.com/onomyprotocol/reserve/x/vaults/types"; | ||
|
|
||
| message ActiveCollateralProposal { |
There was a problem hiding this comment.
We should add a param oracleScriptId to support query price of asset in oracle module
cc: here
|
|
||
| option go_package = "github.com/onomyprotocol/reserve/x/vaults/types"; | ||
|
|
||
| message ActiveCollateralProposal { |
There was a problem hiding this comment.
Should change the name to ActiveCollateralAssetProposal
| return func(ctx sdk.Context, content govtypes.Content) error { | ||
| switch c := content.(type) { | ||
| case *types.ActiveCollateralProposal: | ||
| return k.ActiveCollateralAsset(ctx, c.Denom, c.MinCollateralRatio, c.LiquidationRatio, c.MaxDebt) |
There was a problem hiding this comment.
And in this function, we should call this func to add asset to query list
| @@ -8,5 +8,6 @@ import ( | |||
|
|
|||
| // x/vaults module sentinel errors | |||
| var ( | |||
| ErrInvalidSigner = sdkerrors.Register(ModuleName, 1100, "expected gov account as only signer for proposal message") | |||
| ErrInvalidSigner = sdkerrors.Register(ModuleName, 1100, "expected gov account as only signer for proposal message") | |||
There was a problem hiding this comment.
Register should start from 1
|
|
||
| } | ||
|
|
||
| func NewActiveCollateralProposal(title, description, denom string, minCollateralRatio, liquidationRatio math.LegacyDec, maxDebt math.Int) ActiveCollateralProposal { |
There was a problem hiding this comment.
Should change the name to NewActiveCollateralAssetProposal
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
add gov active-collateral for vaults module
Test: run ./script/vaults-gov-test.sh